linux-kernel - Re: [PATCH 00/20] alienware-wmi driver rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <q57x6dxz5u4vgdhgnowcaxdwczlfam43rf2pwqhvtis665iudf@hrq6d5glx5os>
Date: Wed, 25 Dec 2024 15:36:42 -0500
From: Kurt Borja <kuurtb@...il.com>
To: Armin Wolf <W_Armin@....de>
Cc: platform-driver-x86@...r.kernel.org, ilpo.jarvinen@...ux.intel.com, 
	mario.limonciello@....com, hdegoede@...hat.com, linux-kernel@...r.kernel.org, 
	Dell.Client.Kernel@...l.com
Subject: Re: [PATCH 00/20] alienware-wmi driver rework

On Wed, Dec 25, 2024 at 09:25:35PM +0100, Armin Wolf wrote:
> Am 23.12.24 um 00:06 schrieb Armin Wolf:
> 
> > Am 21.12.24 um 06:58 schrieb Kurt Borja:
> > 
> > > Hi :)
> > > 
> > > Hopefully these series are quite complete now. Your feedback is much
> > > appreciated!
> > > 
> > > Previous discussions:
> > > 
> > > [1]
> > > https://lore.kernel.org/platform-driver-x86/6m66cuivkzhcsvpjv4nunjyddqhr42bmjdhptu4bqm6rm7fvxf@qjwove4hg6gb/
> > > [2]
> > > https://lore.kernel.org/platform-driver-x86/20241205002733.2183537-3-kuurtb@gmail.com/
> > > 
> > > Comments
> > > ========
> > > 
> > > Patches 14 and 20 are proposals. Feel free to NACK them.
> > > 
> > > ~ Kurt
> > 
> > Nice work, i will take a close look at those patches tomorrow.
> > 
> > Thanks,
> > Armin Wolf
> > 
> It seems that i overestimated my time schedule during the Christmas holidays, sorry.
> I will try to review those patches till new year.

Thanks, no worries :) Happy holidays!

~ Kurt

> 
> Thanks,
> Armin Wolf
> 
> > > 
> > > ---
> > > Changes since RFC:
> > >   - Incorporated comments from Ilpo which include style and organization
> > >     issues
> > >   - Instead of splitting functionallity blocks, split WMI drivers
> > > (Due to
> > >     Armin's comments)
> > >   - Replaced most of the patches near the end because of the above
> > > change
> > >   - Some patches were squashed into eachother where it made sense
> > >   - Rebased on top of recent platform_profile changes!
> > > 
> > > Kurt Borja (20):
> > >    alienware-wmi: Remove unnecessary check at module exit
> > >    alienware-wmi: Move Lighting Control State
> > >    alienware-wmi: Modify parse_rgb() signature
> > >    alienware-wmi: Improve hdmi_mux, amplifier and deepslp group creation
> > >    alienware-wmi: Improve rgb-zones group creation
> > >    alienware_wmi: Clean variable declaration in thermal methods
> > >    alienware-wmi: Add a state container for LED control feature
> > >    alienware-wmi: Add WMI Drivers
> > >    alienware-wmi: Add a state container for thermal control methods
> > >    alienware-wmi: Refactor LED control methods
> > >    alienware-wmi: Refactor hdmi, amplifier, deepslp methods
> > >    alienware-wmi: Refactor thermal control methods
> > >    alienware-wmi: Split DMI table
> > >    MAINTAINERS: Update ALIENWARE WMI DRIVER entry
> > >    platform/x86: Rename alienware-wmi.c
> > >    platform/x86: Add alienware-wmi.h
> > >    platform-x86: Split the alienware-wmi driver
> > >    platform/x86: dell: Modify Makefile alignment
> > >    platform/x86: Update alienware-wmi config entries
> > >    alienware-wmi: Update header and module information
> > > 
> > >   MAINTAINERS                                   |    4 +-
> > >   drivers/platform/x86/dell/Kconfig             |   30 +-
> > >   drivers/platform/x86/dell/Makefile            |   45 +-
> > >   .../platform/x86/dell/alienware-wmi-base.c    |  721 ++++++++++
> > >   .../platform/x86/dell/alienware-wmi-legacy.c  |   89 ++
> > >   .../platform/x86/dell/alienware-wmi-wmax.c    |  526 +++++++
> > >   drivers/platform/x86/dell/alienware-wmi.c     | 1269 -----------------
> > >   drivers/platform/x86/dell/alienware-wmi.h     |  103 ++
> > >   8 files changed, 1491 insertions(+), 1296 deletions(-)
> > >   create mode 100644 drivers/platform/x86/dell/alienware-wmi-base.c
> > >   create mode 100644 drivers/platform/x86/dell/alienware-wmi-legacy.c
> > >   create mode 100644 drivers/platform/x86/dell/alienware-wmi-wmax.c
> > >   delete mode 100644 drivers/platform/x86/dell/alienware-wmi.c
> > >   create mode 100644 drivers/platform/x86/dell/alienware-wmi.h
> > > 
> >