linux-kernel - Re: [PATCH v2 1/4] ftrace: Add print_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241225165954.35bcce5f@batman.local.home>
Date: Wed, 25 Dec 2024 16:59:54 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org, Mark
 Rutland <mark.rutland@....com>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Sven Schnelle <svens@...ux.ibm.com>, Paul
 Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>, Guo Ren <guoren@...nel.org>, Donglin
 Peng <dolinux.peng@...il.com>, Zheng Yejian <zhengyejian@...weicloud.com>,
 bpf@...r.kernel.org
Subject: Re: [PATCH v2 1/4] ftrace: Add print_function_args()

On Wed, 25 Dec 2024 22:15:55 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> >  
> > +config FUNCTION_TRACE_ARGS
> > +       bool
> > +	depends on HAVE_FUNCTION_ARG_ACCESS_API
> > +	depends on DEBUG_INFO_BTF  
> 
> For using the BTF APIs, we also needs BPF_SYSCALL (DEBUG_INFO_BTF just
> compiles the BTF info into the kernel binary.)
> 
> Others looks good to me.

Hmm, I removed it due to this feedback:

  https://lore.kernel.org/linux-trace-kernel/20240909225614.4f6d022e58f1276113c8492b@kernel.org/


> 
> Revewied-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Thanks!

-- Steve