linux-kernel - Re: [PATCH 1/1] platform/x86: Add lenovo-legion-wmi drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b1d0298-4cdd-4af7-83e6-9e6287387477@gmail.com>
Date: Wed, 25 Dec 2024 18:25:19 +1300
From: "Cody T.-H. Chiu" <codyit@...il.com>
To: "Derek J. Clark" <derekjohn.clark@...il.com>,
 Hans de Goede <hdegoede@...hat.com>, ike.pan@...onical.com
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Jonathan Corbet <corbet@....net>, Luke Jones <luke@...nes.dev>,
 Xino Ni <nijs1@...ovo.com>, Zhixin Zhang <zhangzx36@...ovo.com>,
 Mia Shao <shaohz1@...ovo.com>, Mark Pearson <mpearson-lenovo@...ebb.ca>,
 "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
 platform-driver-x86@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] platform/x86: Add lenovo-legion-wmi drivers

On 12/17/2024 17:06, Derek J. Clark wrote:
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> ...
> +config LEGION_OTHER_WMI
> +	tristate "Lenovo Legion Other Method WMI Driver"
> +	depends on LEGION_GAMEZONE_WMI
> +	depends on LEGION_DATA_01_WMI
> +	select FW_ATTR_CLASS
> +	help
> +	  Say Y here if you have a WMI aware Lenovo Legion device and would 
like to use the
> +	  firmware_attributes API to control various tunable settings 
typically exposed by
> +	  Lenovo software in Windows.
> +
> +	  To compile this driver as a module, choose M here: the module will
> +	  be called lenovo_legion_wmi_other.
> +
>   config IDEAPAD_LAPTOP
>   	tristate "Lenovo IdeaPad Laptop Extras"
>   	depends on ACPI

Hi Derek,

Thank you for the initiative, love to see we'll finally get a driver 
developed with the help of official specs.

Perhaps it's common knowledge to the crowd here but I'd like to call out 
right now significant portion of the support on Legion ACPI / WMI came 
from ideapad-laptop which explicitly detects it:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/ideapad-laptop.c?h=v6.13-rc4#n2108

Per my observation majority of users have no idea this is the case 
because of the misnomer, adding another set of drivers with Legion in 
the name explicitly, that don't support those features would double the 
dissonance.

I wonder if reconciling this is in your planned scope? If not IMO at 
least this should be called out in documentation / Kconfig.

PS: I'm a developer myself but at lower level kernel domain I'm just a 
user so hopefully I'm not just adding noise here.

- Cody