| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <676bad0d.050a0220.226966.0067.GAE@google.com>
Date: Tue, 24 Dec 2024 22:58:21 -0800
From: syzbot <syzbot+fdf0acb2c5b0b3979515@...kaller.appspotmail.com>
To: adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com, tytso@....edu
Subject: [syzbot] [ext4?] possible deadlock in ext4_readpage_inline
Hello,
syzbot found the following issue on:
HEAD commit: 499551201b5f Merge tag 'arm64-fixes' of git://git.kernel.o..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1753af30580000
kernel config: https://syzkaller.appspot.com/x/.config?x=6a2b862bf4a5409f
dashboard link: https://syzkaller.appspot.com/bug?extid=fdf0acb2c5b0b3979515
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/12df04796e30/disk-49955120.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/48be851df472/vmlinux-49955120.xz
kernel image: https://storage.googleapis.com/syzbot-assets/ca727608fc80/bzImage-49955120.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+fdf0acb2c5b0b3979515@...kaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc3-syzkaller-00209-g499551201b5f #0 Not tainted
------------------------------------------------------
syz.8.5481/20268 is trying to acquire lock:
ffff888078335008 (&ei->xattr_sem){++++}-{4:4}, at: ext4_readpage_inline+0x36/0x590 fs/ext4/inline.c:518
but task is already holding lock:
ffff8880783354d8 (mapping.invalidate_lock){++++}-{4:4}, at: filemap_invalidate_lock_shared include/linux/fs.h:873 [inline]
ffff8880783354d8 (mapping.invalidate_lock){++++}-{4:4}, at: filemap_create_folio mm/filemap.c:2488 [inline]
ffff8880783354d8 (mapping.invalidate_lock){++++}-{4:4}, at: filemap_get_pages+0xdad/0x2080 mm/filemap.c:2555
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #8 (mapping.invalidate_lock){++++}-{4:4}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524
filemap_invalidate_lock_shared include/linux/fs.h:873 [inline]
page_cache_ra_unbounded+0x142/0x720 mm/readahead.c:226
do_async_mmap_readahead mm/filemap.c:3231 [inline]
filemap_fault+0x818/0x1490 mm/filemap.c:3330
__do_fault+0x137/0x390 mm/memory.c:4907
do_read_fault mm/memory.c:5322 [inline]
do_fault mm/memory.c:5456 [inline]
do_pte_missing mm/memory.c:3979 [inline]
handle_pte_fault+0x39eb/0x5ed0 mm/memory.c:5801
__handle_mm_fault mm/memory.c:5944 [inline]
handle_mm_fault+0x1106/0x1bb0 mm/memory.c:6112
faultin_page mm/gup.c:1196 [inline]
__get_user_pages+0x1c82/0x49e0 mm/gup.c:1494
__get_user_pages_locked mm/gup.c:1760 [inline]
get_dump_page+0x155/0x2f0 mm/gup.c:2278
dump_user_range+0x14d/0x970 fs/coredump.c:943
elf_core_dump+0x3e9f/0x4790 fs/binfmt_elf.c:2129
do_coredump+0x229d/0x3100 fs/coredump.c:758
get_signal+0x140b/0x1750 kernel/signal.c:3002
arch_do_signal_or_restart+0x96/0x860 arch/x86/kernel/signal.c:337
exit_to_user_mode_loop kernel/entry/common.c:111 [inline]
exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline]
irqentry_exit_to_user_mode+0x7e/0x250 kernel/entry/common.c:231
exc_page_fault+0x590/0x8b0 arch/x86/mm/fault.c:1542
asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623
-> #7 (&mm->mmap_lock){++++}-{4:4}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
__might_fault+0xc6/0x120 mm/memory.c:6751
_inline_copy_from_user include/linux/uaccess.h:162 [inline]
_copy_from_user+0x2a/0xc0 lib/usercopy.c:18
copy_from_user include/linux/uaccess.h:212 [inline]
__blk_trace_setup kernel/trace/blktrace.c:626 [inline]
blk_trace_ioctl+0x1ad/0x9a0 kernel/trace/blktrace.c:740
blkdev_ioctl+0x40c/0x6a0 block/ioctl.c:682
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl+0xf7/0x170 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #6 (&q->debugfs_mutex){+.+.}-{4:4}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
__mutex_lock_common kernel/locking/mutex.c:585 [inline]
__mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735
blk_mq_init_sched+0x3fa/0x830 block/blk-mq-sched.c:473
elevator_init_mq+0x20e/0x320 block/elevator.c:610
add_disk_fwnode+0x10d/0xf80 block/genhd.c:413
sd_probe+0xba6/0x1100 drivers/scsi/sd.c:4024
really_probe+0x2ba/0xad0 drivers/base/dd.c:658
__driver_probe_device+0x1a2/0x390 drivers/base/dd.c:800
driver_probe_device+0x50/0x430 drivers/base/dd.c:830
__device_attach_driver+0x2d6/0x530 drivers/base/dd.c:958
bus_for_each_drv+0x250/0x2e0 drivers/base/bus.c:459
__device_attach_async_helper+0x22d/0x300 drivers/base/dd.c:987
async_run_entry_fn+0xaa/0x420 kernel/async.c:129
process_one_work kernel/workqueue.c:3229 [inline]
process_scheduled_works+0xa68/0x1840 kernel/workqueue.c:3310
worker_thread+0x870/0xd30 kernel/workqueue.c:3391
kthread+0x2f2/0x390 kernel/kthread.c:389
ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
-> #5 (&q->q_usage_counter(queue)#50){++++}-{0:0}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
blk_queue_enter+0xe1/0x600 block/blk-core.c:328
blk_mq_alloc_request+0x4fa/0xaa0 block/blk-mq.c:652
scsi_alloc_request drivers/scsi/scsi_lib.c:1222 [inline]
scsi_execute_cmd+0x177/0x1090 drivers/scsi/scsi_lib.c:304
read_capacity_16+0x2b4/0x1450 drivers/scsi/sd.c:2655
sd_read_capacity drivers/scsi/sd.c:2824 [inline]
sd_revalidate_disk+0x1013/0xbce0 drivers/scsi/sd.c:3734
sd_probe+0x9fa/0x1100 drivers/scsi/sd.c:4010
really_probe+0x2ba/0xad0 drivers/base/dd.c:658
__driver_probe_device+0x1a2/0x390 drivers/base/dd.c:800
driver_probe_device+0x50/0x430 drivers/base/dd.c:830
__device_attach_driver+0x2d6/0x530 drivers/base/dd.c:958
bus_for_each_drv+0x250/0x2e0 drivers/base/bus.c:459
__device_attach_async_helper+0x22d/0x300 drivers/base/dd.c:987
async_run_entry_fn+0xaa/0x420 kernel/async.c:129
process_one_work kernel/workqueue.c:3229 [inline]
process_scheduled_works+0xa68/0x1840 kernel/workqueue.c:3310
worker_thread+0x870/0xd30 kernel/workqueue.c:3391
kthread+0x2f2/0x390 kernel/kthread.c:389
ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
-> #4 (&q->limits_lock){+.+.}-{4:4}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
__mutex_lock_common kernel/locking/mutex.c:585 [inline]
__mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735
queue_limits_start_update include/linux/blkdev.h:947 [inline]
loop_reconfigure_limits+0x43f/0x900 drivers/block/loop.c:998
loop_set_block_size drivers/block/loop.c:1473 [inline]
lo_simple_ioctl drivers/block/loop.c:1496 [inline]
lo_ioctl+0x1351/0x1f50 drivers/block/loop.c:1559
blkdev_ioctl+0x57f/0x6a0 block/ioctl.c:693
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl+0xf7/0x170 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #3 (&q->q_usage_counter(io)#24){++++}-{0:0}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
bio_queue_enter block/blk.h:75 [inline]
blk_mq_submit_bio+0x1536/0x2390 block/blk-mq.c:3090
__submit_bio+0x2c6/0x560 block/blk-core.c:629
__submit_bio_noacct_mq block/blk-core.c:710 [inline]
submit_bio_noacct_nocheck+0x4d3/0xe30 block/blk-core.c:739
__ext4_read_bh fs/ext4/super.c:181 [inline]
ext4_read_bh+0x1d7/0x290 fs/ext4/super.c:206
ext4_bread+0x135/0x180 fs/ext4/inode.c:918
ext4_quota_read+0x1b8/0x2d0 fs/ext4/super.c:7239
read_blk fs/quota/quota_tree.c:61 [inline]
find_tree_dqentry+0x1e5/0xfb0 fs/quota/quota_tree.c:671
find_tree_dqentry+0x6cd/0xfb0 fs/quota/quota_tree.c:698
find_tree_dqentry+0x6cd/0xfb0 fs/quota/quota_tree.c:698
find_tree_dqentry+0x6cd/0xfb0 fs/quota/quota_tree.c:698
find_dqentry fs/quota/quota_tree.c:716 [inline]
qtree_read_dquot+0x53e/0x7e0 fs/quota/quota_tree.c:736
v2_read_dquot+0x11e/0x200 fs/quota/quota_v2.c:344
dquot_acquire+0x194/0x680 fs/quota/dquot.c:461
ext4_acquire_dquot+0x301/0x4c0 fs/ext4/super.c:6934
dqget+0x772/0xeb0 fs/quota/dquot.c:977
__dquot_initialize+0x468/0xec0 fs/quota/dquot.c:1505
ext4_xattr_set+0x109/0x3e0 fs/ext4/xattr.c:2544
__vfs_setxattr+0x46a/0x4a0 fs/xattr.c:200
__vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234
vfs_setxattr+0x221/0x430 fs/xattr.c:321
do_setxattr fs/xattr.c:636 [inline]
filename_setxattr+0x2af/0x430 fs/xattr.c:665
path_setxattrat+0x440/0x510 fs/xattr.c:713
__do_sys_lsetxattr fs/xattr.c:754 [inline]
__se_sys_lsetxattr fs/xattr.c:750 [inline]
__x64_sys_lsetxattr+0xbf/0xe0 fs/xattr.c:750
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #2 (&s->s_dquot.dqio_sem){++++}-{4:4}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524
v2_read_dquot+0x57/0x200 fs/quota/quota_v2.c:342
dquot_acquire+0x194/0x680 fs/quota/dquot.c:461
ext4_acquire_dquot+0x301/0x4c0 fs/ext4/super.c:6934
dqget+0x772/0xeb0 fs/quota/dquot.c:977
__dquot_initialize+0x468/0xec0 fs/quota/dquot.c:1505
ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329
ext4_orphan_cleanup+0xb77/0x13d0 fs/ext4/orphan.c:474
__ext4_fill_super fs/ext4/super.c:5610 [inline]
ext4_fill_super+0x64dc/0x6e60 fs/ext4/super.c:5733
get_tree_bdev_flags+0x48e/0x5c0 fs/super.c:1636
vfs_get_tree+0x92/0x2b0 fs/super.c:1814
do_new_mount+0x2be/0xb40 fs/namespace.c:3507
do_mount fs/namespace.c:3847 [inline]
__do_sys_mount fs/namespace.c:4057 [inline]
__se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #1 (&dquot->dq_lock){+.+.}-{4:4}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
__mutex_lock_common kernel/locking/mutex.c:585 [inline]
__mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735
wait_on_dquot fs/quota/dquot.c:354 [inline]
dqget+0x6e6/0xeb0 fs/quota/dquot.c:972
dquot_transfer+0x2c2/0x6d0 fs/quota/dquot.c:2140
ext4_setattr+0xb49/0x1da0 fs/ext4/inode.c:5400
notify_change+0xbcc/0xe90 fs/attr.c:552
chown_common+0x501/0x850 fs/open.c:778
do_fchownat+0x16a/0x240 fs/open.c:809
__do_sys_lchown fs/open.c:834 [inline]
__se_sys_lchown fs/open.c:832 [inline]
__x64_sys_lchown+0x85/0xa0 fs/open.c:832
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #0 (&ei->xattr_sem){++++}-{4:4}:
check_prev_add kernel/locking/lockdep.c:3161 [inline]
check_prevs_add kernel/locking/lockdep.c:3280 [inline]
validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
__lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524
ext4_readpage_inline+0x36/0x590 fs/ext4/inline.c:518
ext4_read_folio+0x174/0x340 fs/ext4/inode.c:3185
filemap_read_folio+0x14a/0x3b0 mm/filemap.c:2366
filemap_create_folio mm/filemap.c:2497 [inline]
filemap_get_pages+0x1099/0x2080 mm/filemap.c:2555
filemap_read+0x452/0xf50 mm/filemap.c:2646
__kernel_read+0x515/0x9d0 fs/read_write.c:523
integrity_kernel_read+0xb0/0x100 security/integrity/iint.c:28
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:480 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:511 [inline]
ima_calc_file_hash+0xae6/0x1b30 security/integrity/ima/ima_crypto.c:568
ima_collect_measurement+0x520/0xb10 security/integrity/ima/ima_api.c:293
process_measurement+0x1351/0x1fb0 security/integrity/ima/ima_main.c:372
ima_file_check+0xd9/0x120 security/integrity/ima/ima_main.c:572
security_file_post_open+0xb9/0x280 security/security.c:3121
do_open fs/namei.c:3830 [inline]
path_openat+0x2ccd/0x3590 fs/namei.c:3987
do_filp_open+0x27f/0x4e0 fs/namei.c:4014
do_sys_openat2+0x13e/0x1d0 fs/open.c:1402
do_sys_open fs/open.c:1417 [inline]
__do_sys_openat fs/open.c:1433 [inline]
__se_sys_openat fs/open.c:1428 [inline]
__x64_sys_openat+0x247/0x2a0 fs/open.c:1428
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
other info that might help us debug this:
Chain exists of:
&ei->xattr_sem --> &mm->mmap_lock --> mapping.invalidate_lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
rlock(mapping.invalidate_lock);
lock(&mm->mmap_lock);
lock(mapping.invalidate_lock);
rlock(&ei->xattr_sem);
*** DEADLOCK ***
3 locks held by syz.8.5481/20268:
#0: ffff888057bee420 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:515
#1: ffff88802a07c6c8 (&ima_iint_mutex_key[depth]){+.+.}-{4:4}, at: process_measurement+0x7a6/0x1fb0 security/integrity/ima/ima_main.c:269
#2: ffff8880783354d8 (mapping.invalidate_lock){++++}-{4:4}, at: filemap_invalidate_lock_shared include/linux/fs.h:873 [inline]
#2: ffff8880783354d8 (mapping.invalidate_lock){++++}-{4:4}, at: filemap_create_folio mm/filemap.c:2488 [inline]
#2: ffff8880783354d8 (mapping.invalidate_lock){++++}-{4:4}, at: filemap_get_pages+0xdad/0x2080 mm/filemap.c:2555
stack backtrace:
CPU: 1 UID: 0 PID: 20268 Comm: syz.8.5481 Not tainted 6.13.0-rc3-syzkaller-00209-g499551201b5f #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074
check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206
check_prev_add kernel/locking/lockdep.c:3161 [inline]
check_prevs_add kernel/locking/lockdep.c:3280 [inline]
validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
__lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524
ext4_readpage_inline+0x36/0x590 fs/ext4/inline.c:518
ext4_read_folio+0x174/0x340 fs/ext4/inode.c:3185
filemap_read_folio+0x14a/0x3b0 mm/filemap.c:2366
filemap_create_folio mm/filemap.c:2497 [inline]
filemap_get_pages+0x1099/0x2080 mm/filemap.c:2555
filemap_read+0x452/0xf50 mm/filemap.c:2646
__kernel_read+0x515/0x9d0 fs/read_write.c:523
integrity_kernel_read+0xb0/0x100 security/integrity/iint.c:28
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:480 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:511 [inline]
ima_calc_file_hash+0xae6/0x1b30 security/integrity/ima/ima_crypto.c:568
ima_collect_measurement+0x520/0xb10 security/integrity/ima/ima_api.c:293
process_measurement+0x1351/0x1fb0 security/integrity/ima/ima_main.c:372
ima_file_check+0xd9/0x120 security/integrity/ima/ima_main.c:572
security_file_post_open+0xb9/0x280 security/security.c:3121
do_open fs/namei.c:3830 [inline]
path_openat+0x2ccd/0x3590 fs/namei.c:3987
do_filp_open+0x27f/0x4e0 fs/namei.c:4014
do_sys_openat2+0x13e/0x1d0 fs/open.c:1402
do_sys_open fs/open.c:1417 [inline]
__do_sys_openat fs/open.c:1433 [inline]
__se_sys_openat fs/open.c:1428 [inline]
__x64_sys_openat+0x247/0x2a0 fs/open.c:1428
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fa6ccd85d29
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa6cdb1c038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007fa6ccf75fa0 RCX: 00007fa6ccd85d29
RDX: 0000000000020243 RSI: 0000000020000100 RDI: ffffffffffffff9c
RBP: 00007fa6cce01aa8 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fa6ccf75fa0 R15: 00007ffe9e9c0dd8
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@...glegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
Powered by blists - more mailing lists