linux-kernel - RE: [EXT] Re: [PATCH v20 1/9] soc: cadence: Create helper functions for Cadence MHDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DB9PR04MB9452836ADDB545CA3B5B0FC7F40C2@DB9PR04MB9452.eurprd04.prod.outlook.com>
Date: Wed, 25 Dec 2024 07:56:15 +0000
From: Sandor Yu <sandor.yu@....com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>, Laurent Pinchart
	<laurent.pinchart@...asonboard.com>, "jonas@...boo.se" <jonas@...boo.se>,
	"jernej.skrabec@...il.com" <jernej.skrabec@...il.com>, "airlied@...il.com"
	<airlied@...il.com>, "daniel@...ll.ch" <daniel@...ll.ch>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>,
	"vkoul@...nel.org" <vkoul@...nel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-phy@...ts.infradead.org"
	<linux-phy@...ts.infradead.org>, "mripard@...nel.org" <mripard@...nel.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>, dl-linux-imx
	<linux-imx@....com>, Oliver Brown <oliver.brown@....com>,
	"alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
	"sam@...nborg.org" <sam@...nborg.org>
Subject: RE: [EXT] Re: [PATCH v20 1/9] soc: cadence: Create helper functions
 for Cadence MHDP

 
> 
> On Tue, Dec 17, 2024 at 02:51:43PM +0800, Sandor Yu wrote:
> > Cadence MHDP IP includes a firmware. Driver and firmware communicate
> > through a mailbox. The basic mailbox access functions in this patch
> > are derived from the DRM bridge MHDP8546 driver.
> > New mailbox access functions have been created based on different
> > mailbox return values and security types, making them reusable across
> > different MHDP driver versions and SOCs.
> >
> > These helper fucntions will be reused in both the DRM bridge driver
> > MDHP8501 and the i.MX8MQ HDPTX PHY driver.
> >
> > Six mailbox access helper functions are introduced.
> > Three for non-secure mailbox access:
> >  - cdns_mhdp_mailbox_send()
> >  - cdns_mhdp_mailbox_send_recv()
> >  - cdns_mhdp_mailbox_send_recv_multi()
> > The other three for secure mailbox access:
> >  - cdns_mhdp_secure_mailbox_send()
> >  - cdns_mhdp_secure_mailbox_send_recv()
> >  - cdns_mhdp_secure_mailbox_send_recv_multi()
> >
> > All MHDP commands that need to be passed through the mailbox should be
> > rewritten using these new helper functions.
> >
> > The register read/write and DP DPCD read/write command functions are
> > also included in this new helper driver.
> >
> > Signed-off-by: Sandor Yu <Sandor.yu@....com>
> > ---
> > v19->v20:
> > - new patch in v20.
> >   The patch split from Patch #1 in v19 and move to a new folder
> > drivers/soc/cadence
> 
> It makes it harder to review, but granted that we have already past that, I
> think it's fine.
> 
> >
> > diff --git a/drivers/soc/cadence/Kconfig b/drivers/soc/cadence/Kconfig
> > new file mode 100644 index 0000000000000..b668790660fa5
> > --- /dev/null
> > +++ b/drivers/soc/cadence/Kconfig
> > @@ -0,0 +1,9 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +config CDNS_MHDP_HELPER
> > +     tristate "Cadence MHDP Helper driver"
> 
> This symbol isn't supposed to be selected by the user. Please leave just
> tristate without the menu entry text (the help text is fine, please keep it).
> 
> LGTM otherwise.

OK, thanks, I will remove the menu entry text.

B.R
Sandor

> 
> > +     help
> > +       Enable Cadence MHDP helpers for mailbox, HDMI and DP.
> > +       This driver provides a foundational layer of mailbox
> communication for
> > +       various Cadence MHDP IP implementations, such as HDMI and
> DisplayPort.
> > +
> 
> --
> With best wishes
> Dmitry