linux-kernel - Re: [PATCH] platform/x86: hp-wmi: mark 8A15 board for timed OMEN thermal profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c5bdef1-9201-4d38-a6e0-6acd95d8aa38@aosc.io>
Date: Thu, 26 Dec 2024 14:03:08 +0800
From: Mingcong Bai <jeffbai@...c.io>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Alexis Belmonte <alexbelm48@...il.com>,
 Hans de Goede <hdegoede@...hat.com>, Armin Wolf <W_Armin@....de>,
 Kexy Biscuit <kexybiscuit@...c.io>, xiaoxi404 <1577912515@...com>,
 Ai Chao <aichao@...inos.cn>, Uwe Kleine-König
 <u.kleine-koenig@...libre.com>, platform-driver-x86@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: hp-wmi: mark 8A15 board for timed OMEN
 thermal profile

Hi Ilpo,

Sorry for the late reply but your email fell through the cracks.

在 2024/12/24 03:15, Ilpo Järvinen 写道:
> On Mon, 23 Dec 2024, Mingcong Bai wrote:
> 
>> From: xiaoxi404 <1577912515@...com>
>>
>> The HP OMEN 8 (2022), corresponding to a board ID of 8A15, supports OMEN
>> thermal profile and requires the timed profile quirk.
>>
>> Upon adding this ID to both the omen_thermal_profile_boards and
>> omen_timed_thermal_profile_boards, significant bump in performance can be
>> observed. For instance, SilverBench (https://silver.urih.com/) results
>> improved from ~56,000 to ~69,000, as a result of higher power draws (and
>> thus core frequencies) whilst under load:
>>
>> Package Power:
>>
>> - Before the patch: ~65W (dropping to about 55W under sustained load).
>> - After the patch: ~115W (dropping to about 105W under sustained load).
>>
>> Core Power:
>>
>> - Before: ~60W (ditto above).
>> - After: ~108W (ditto above).
>>
>> Add 8A15 to omen_thermal_profile_boards and
>> omen_timed_thermal_profile_boards to improve performance.
>>
>> Signed-off-by: xiaoxi404 <1577912515@...com>
>> Signed-off-by: Mingcong Bai <jeffbai@...c.io>
> 
> Hi,
> 
> I wanted to apply this but the first signed-off-by line threw me off. It
> should contain person's name before the email address line like yours does
> (assuming the first signed-off-by is necessary in the first place, the
> patch itself looks quite trivial given it's just about adding one ID).
> 

Understood, but that is how this person represents themselves online. If 
that is indeed a problem, I can consult them for how this should be handled.

Best Regards,
Mingcong Bai