linux-kernel - Re: [PATCH v6 1/1] dt-bindings: bluetooth: update the wcn6750 required properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7b75672-4885-491c-9797-906261979e15@quicinc.com>
Date: Thu, 26 Dec 2024 11:41:04 +0530
From: Janaki Ramaiah Thota <quic_janathot@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Marcel Holtmann <marcel@...tmann.org>,
        Luiz Augusto von Dentz
	<luiz.dentz@...il.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "Balakrishna
 Godavarthi" <quic_bgodavar@...cinc.com>,
        Rocky Liao
	<quic_rjliao@...cinc.com>, <quic_mohamull@...cinc.com>,
        <quic_hbandi@...cinc.com>, <quic_anubhavg@...cinc.com>,
        <linux-bluetooth@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 1/1] dt-bindings: bluetooth: update the wcn6750
 required properties



On 12/24/2024 6:57 PM, Krzysztof Kozlowski wrote:
> On 24/12/2024 12:51, Janaki Ramaiah Thota wrote:
>>
>>
>> On 12/24/2024 2:46 PM, Krzysztof Kozlowski wrote:
>>> On Mon, Dec 23, 2024 at 07:27:00PM +0530, Janaki Ramaiah Thota wrote:
>>>
>>> Subject: everything is an update... say something useful, e.g. use PMU
>>> abstraction for WCN6750
>>>
>>
>> Sure will correct it in next patch.
>>
>>>> Drop the inputs from the host and instead expect the Bluetooth node to
>>>> consume the outputs of the internal PMU.
>>>
>>> On which device?
>>>
>>
>> It is for BT module wcn6750 attached on qcs6490-rb3gen2 board.
>> will update same on next commit message.
>>
>>> But anyway I have doubts this is correct. enable GPIO is a pin going
>>> from the host, not from PMU.
>>>
>>
>> Yes you are correct, enable GPIO is out pin of host, but here updated
>> the entries required for Bluetooth node from PMU, not from host to PMU.
> 
> Hm? No, you removed for example enable-gpios, which is input from the
> host. Sorry, I don't understand the reason behind this patch and commit
> msg does not help me there.
> 

We are migrating to powerseq for the WCN6750. As per Dmitry’s 
suggestion, we are now using the on-chip PMU, which necessitates the 
removal of some entries that are not mandatory to avoid binding errors. 
For example, the enable GPIO is now handled by the PMU with property 
bt-enable-gpios, as shown in the patch linked below
https://lore.kernel.org/linux-arm-msm/20241209103455.9675-3-quic_janathot@quicinc.com/

Thanks,
Janakiram