linux-kernel - Re: [PATCH v7] i2c: imx: support DMA defer probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <zxsnqol4qmy7p5vxs525zf3xp7dwx4pqh4lbp2mz25kyaqr44q@n4s6mps6o4ub>
Date: Thu, 26 Dec 2024 10:29:42 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Carlos Song <carlos.song@....com>
Cc: frank.li@....com, o.rempel@...gutronix.de, kernel@...gutronix.de, 
	shawnguo@...nel.org, s.hauer@...gutronix.de, festevam@...il.com, 
	linux-i2c@...r.kernel.org, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, Clark Wang <xiaoning.wang@....com>, 
	Ahmad Fatoum <a.fatoum@...gutronix.de>
Subject: Re: [PATCH v7] i2c: imx: support DMA defer probing

Hi Carlos,

On Thu, Dec 26, 2024 at 02:25:21PM +0800, Carlos Song wrote:
> Return -EPROBE_DEFER when dma_request_slave_channel() because DMA driver
> have not ready yet.
> 
> Move i2c_imx_dma_request() before registering I2C adapter to avoid
> infinite loop of .probe() calls to the same driver, see "e8c220fac415
> Revert "i2c: imx: improve the error handling in i2c_imx_dma_request()""
> and "Documentation/driver-api/driver-model/driver.rst".
> 
> Use CPU mode to avoid stuck registering i2c adapter when DMA resources
> are unavailable.
> 
> Signed-off-by: Carlos Song <carlos.song@....com>
> Signed-off-by: Clark Wang <xiaoning.wang@....com>
> Acked-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
> Acked-by: Oleksij Rempel <o.rempel@...gutronix.de>

thanks for following up on all your comments! Merged to
i2c/i2c-host.

Thanks,
Andi