linux-kernel - Re: [PATCH v2] Update USB/IP OP_REP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e4e933e-ea26-495f-a35e-583ebcf4dac4@linuxfoundation.org>
Date: Thu, 26 Dec 2024 11:28:02 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Gordon Ou <gordon.xwj@...il.com>,
 Valentina Manea <valentina.manea.m@...il.com>, Shuah Khan <shuah@...nel.org>
Cc: Hongren Zheng <i@...ithal.me>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jonathan Corbet <corbet@....net>, linux-usb@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, trivial@...nel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] Update USB/IP OP_REP_IMPORT documentation.

On 12/23/24 23:23, Gordon Ou wrote:
> This is to correct the mistaken byte offset of the field bDeviceClass in
> OP_REP_IMPORT documentation. The previous field bcdDevice has length 2 and
> the offset for bDeviceClass should be 0x138 + 2 = 0x13A instead of 0x139.
> Offsets for subsequent fields are also affected and fixed in this patch.
> 
> Signed-off-by: Gordon Ou <gordon.xwj@...il.com>
> ---
> Changes in v2:
>   - Updated patch description.

Looks good to me.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

Greg, please pick this up.

thanks,
-- Shuah