linux-kernel - Re: [PATCH 2/2] hyperv: Do not overlap the input and output hypercall areas in get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2262a520-5557-45cc-95c0-460ebad30b01@linux.microsoft.com>
Date: Thu, 26 Dec 2024 12:42:43 -0800
From: Roman Kisel <romank@...ux.microsoft.com>
To: Michael Kelley <mhklinux@...look.com>, Wei Liu <wei.liu@...nel.org>
Cc: "hpa@...or.com" <hpa@...or.com>, "kys@...rosoft.com" <kys@...rosoft.com>,
 "bp@...en8.de" <bp@...en8.de>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
 "decui@...rosoft.com" <decui@...rosoft.com>,
 "eahariha@...ux.microsoft.com" <eahariha@...ux.microsoft.com>,
 "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>,
 "mingo@...hat.com" <mingo@...hat.com>,
 "nunodasneves@...ux.microsoft.com" <nunodasneves@...ux.microsoft.com>,
 "tglx@...utronix.de" <tglx@...utronix.de>,
 "tiala@...rosoft.com" <tiala@...rosoft.com>,
 "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "x86@...nel.org" <x86@...nel.org>, "apais@...rosoft.com"
 <apais@...rosoft.com>, "benhill@...rosoft.com" <benhill@...rosoft.com>,
 "ssengar@...rosoft.com" <ssengar@...rosoft.com>,
 "sunilmut@...rosoft.com" <sunilmut@...rosoft.com>,
 "vdso@...bites.dev" <vdso@...bites.dev>
Subject: Re: [PATCH 2/2] hyperv: Do not overlap the input and output hypercall
 areas in get_vtl(void)



On 12/26/2024 12:04 PM, Michael Kelley wrote:
[...]

> 
> As I was looking at how hypercall input and output arguments are
> managed in upstream code and in the OHCL-Linux-Kernel repo,
> I noticed two things:
> 
> 1) There's a bug in mshv_vtl_hvcall_call() in the OHCL-Linux-Kernel
> repo, for which I filed a github issue. [1]
Appreciated very much!

> 
> 2) hv_vtl_apicid_to_vp_id() also has the overlapping hypercall input
> and output spec violation. You might want to fix that occurrence as
> well in this patch set.
Let me do that, thank you!

> 
> Michael
> 
> [1] https://github.com/microsoft/OHCL-Linux-Kernel/issues/33

-- 
Thank you,
Roman