linux-kernel - Re: [PATCH v7 01/18] tools: Add gendwarfksyms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATRGzGjLLcv+aD3KdgkZXzwMsCSud116rzEThNXRQC0rw@mail.gmail.com>
Date: Fri, 27 Dec 2024 15:01:25 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Sami Tolvanen <samitolvanen@...gle.com>
Cc: Luis Chamberlain <mcgrof@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Matthew Maurer <mmaurer@...gle.com>, 
	Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, 
	Petr Pavlu <petr.pavlu@...e.com>, Daniel Gomez <da.gomez@...sung.com>, Neal Gompa <neal@...pa.dev>, 
	Hector Martin <marcan@...can.st>, Janne Grunau <j@...nau.net>, Miroslav Benes <mbenes@...e.cz>, 
	Asahi Linux <asahi@...ts.linux.dev>, Sedat Dilek <sedat.dilek@...il.com>, 
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-modules@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v7 01/18] tools: Add gendwarfksyms

On Fri, Dec 20, 2024 at 6:07 AM Sami Tolvanen <samitolvanen@...gle.com> wrote:

> +int main(int argc, char **argv)
> +{
> +       unsigned int n;
> +       int opt;
> +
> +       struct option opts[] = { { "debug", 0, NULL, 'd' },

You can add "static const" to opts[] here.

I like the array initializer formatted like follows:

static const struct option opts[] = {
        { "debug", 0, NULL, 'd' },
        { "dump-dies", 0, &dump_dies, 1 },
        { "help", 0, NULL, 'h' },
        { 0, 0, NULL, 0 }
};





> +                                { "dump-dies", 0, &dump_dies, 1 },
> +                                { "help", 0, NULL, 'h' },
> +                                { 0, 0, NULL, 0 } };
> +



--
Best Regards
Masahiro Yamada