linux-kernel - Re: [PATCH v5 03/10] dt-bindings: media: Add amlogic,c3-mipi-adapter.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4dca976-3cce-49e7-bb06-25219623d987@linaro.org>
Date: Fri, 27 Dec 2024 08:20:16 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: keke.li@...ogic.com, Mauro Carvalho Chehab <mchehab@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kieran.bingham@...asonboard.com,
 laurent.pinchart@...asonboard.com, dan.scally@...asonboard.com,
 jacopo.mondi@...asonboard.com
Subject: Re: [PATCH v5 03/10] dt-bindings: media: Add
 amlogic,c3-mipi-adapter.yaml

On 27/12/2024 08:09, Keke Li via B4 Relay wrote:
> From: Keke Li <keke.li@...ogic.com>
> 
> c3-mipi-adapter is used to organize mipi data and
> send raw data to ISP module.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Keke Li <keke.li@...ogic.com>
> ---
>  .../bindings/media/amlogic,c3-mipi-adapter.yaml    | 115 +++++++++++++++++++++
>  MAINTAINERS                                        |   6 ++
>  2 files changed, 121 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml
> new file mode 100644
> index 000000000000..1105fee2d7a8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml
> @@ -0,0 +1,115 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-adapter.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic C3 MIPI adapter receiver
> +
> +maintainers:
> +  - Keke Li <keke.li@...ogic.com>
> +
> +description:
> +  MIPI adapter is used to convert the MIPI CSI-2 data
> +  into an ISP supported data format.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - amlogic,c3-mipi-adapter
> +
> +  reg:
> +    maxItems: 3
> +
> +  reg-names:
> +    items:
> +      - const: top
> +      - const: fd
> +      - const: rd
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: vapb
> +      - const: isp0
> +
> +  assigned-clocks: true
> +
> +  assigned-clock-rates: true

NAK. Drop my review tag. You cannot keep someone's review while making
significant changes. Please carefully read submitting patches before
next posting.


Best regards,
Krzysztof