linux-kernel - Re: [PATCH] usb: typec: ucsi: make yoga_c630_ucsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024122743-operable-treading-aa03@gregkh>
Date: Fri, 27 Dec 2024 08:54:25 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Pei Xiao <xiaopei01@...inos.cn>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	heikki.krogerus@...ux.intel.com, dmitry.baryshkov@...aro.org,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] usb: typec: ucsi: make yoga_c630_ucsi_ops be static

On Fri, Dec 27, 2024 at 01:51:51PM +0800, Pei Xiao wrote:
> sparse warnings:
>     drivers/usb/typec/ucsi/ucsi_yoga_c630.c:101:30: sparse: sparse:
>     symbol 'yoga_c630_ucsi_ops' was not declared. Should it be static?
> 

That's a nice warning message, but doesn't explain what this change is
actually doing.  Please read the kernel documentation for how to
properly write a changelog commit for what needs to go here.

thanks,

greg k-h