linux-kernel - Re: [PATCH v2] dt-bindings: iio: light: opt3001: add compatible for opt3004

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x6rl2gmvwkn7lidilo23lxwqwwkilesymo7lxk2uygvtietemh@qhbx4lj6r7eh>
Date: Fri, 27 Dec 2024 09:45:10 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
Cc: jic23@...nel.org, krzk+dt@...nel.org, 
	andriy.shevchenko@...ux.intel.com, Lars-Peter Clausen <lars@...afoo.de>, 
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Emil Gedenryd <emil.gedenryd@...s.com>, Andreas Dannenberg <dannenberg@...com>, 
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: iio: light: opt3001: add compatible for
 opt3004

On Thu, Dec 26, 2024 at 06:47:35PM +0530, Hardevsinh Palaniya wrote:
> Add Support for OPT3004 Digital ambient light sensor (ALS) with
> increased angular IR rejection.
> 
> The OPT3004 sensor shares the same functionality and scale range as
> the OPT3001. the compatible string is added with fallback support to
> ensure compatibility.
> 
> Datasheet: https://www.ti.com/lit/gpn/opt3004
> 
> Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
> ---
> 
> v1 -> v2:
> 
> - Use fallback mechanism for the OPT3004.
> - Drop 2/2 patch from the patch series[1] as per feedback.
> 
> Link[1]: https://lore.kernel.org/linux-iio/20241224061321.6048-1-hardevsinh.palaniya@siliconsignals.io/T/#t
> 
> ---
>  .../devicetree/bindings/iio/light/ti,opt3001.yaml      | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> index 67ca8d08256a..56844710e79a 100644
> --- a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> @@ -15,9 +15,13 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - ti,opt3001
> -      - ti,opt3002
> +    oneOf:
> +      - enum:
> +          - ti,opt3001
> +          - ti,opt3002
> +      - items:
> +          - const: ti,opt3001
> +          - const: ti,opt3004

3004 is not the fallback.

Best regards,
Krzysztof