linux-kernel - Re: [PATCH] drm/mediatek: Initialize pointer before use to avoid undefiend behaviour

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tte6ad3rxle52x3wndewyyrnszozghvpxktx2x55w26rdcea4n@rdbhzpx2wi3p>
Date: Fri, 27 Dec 2024 09:51:25 +0000
From: Karan Sanghavi <karansanghvi98@...il.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, Alexandre Mergnat <amergnat@...libre.com>, 
	Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Chun-Kuang Hu <chunkuang.hu@...nel.org>, 
	David Airlie <airlied@...il.com>, Matthias Brugger <matthias.bgg@...il.com>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Shuah Khan <skhan@...uxfoundation.org>, 
	Simona Vetter <simona@...ll.ch>, Sui Jingfeng <sui.jingfeng@...ux.dev>, 
	LKML <linux-kernel@...r.kernel.org>, CK Hu (胡俊光) <ck.hu@...iatek.com>
Subject: Re: [PATCH] drm/mediatek: Initialize pointer before use to avoid
 undefiend behaviour

On Tue, Dec 24, 2024 at 05:09:54PM +0100, Markus Elfring wrote:
> > Initialize the pointer with NULL as mtk_drm_of_get_ddp_ep_cid
> > function might return before assigning value to next pointer
> > but yet further dereference to next can lead to some undefined
> > behavior as it may point to some invalid location.
> 
> * You may occasionally put more than 62 characters into text lines
>   of such a change description.
> 
> * Please avoid a typo the summary phrase.
> 
yes sure. will keep that in mind for hte next patch. 
> 
> …
> > ---
> > Coverity Message:
> > CID 1601557: (#1 of 1): Uninitialized pointer read (UNINIT)
> > 3. uninit_use: Using uninitialized value next.
> 
> May such information become a part for the final change description?
>
Ofcourse, it shouldn't be the part of the change description. Thus i
have added them after the '---' due to which it wouldn't be the part of
the commit log (that's my uderstanding correct me if i am wrong). If it
still adds in the commit log do let me know as it hasn't been added for
other patches. 

it is just for the reference to understand more about what the error message
is generated by coverity scan.

Thank you,
karan.
> Regards,
> Markus