linux-kernel - Re: [PATCH v2] mm: shmem: Fix variable type to int to evaluate negative conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x66swoe4pvdfrnsm5ruq5fd54shfoqz363p3r7fschn6m63qp2@waljdkeoq4eu>
Date: Fri, 27 Dec 2024 10:01:04 +0000
From: Karan Sanghavi <karansanghvi98@...il.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-mm@...ck.org, 
	André Almeida <andrealmeid@...lia.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Christian Brauner <brauner@...nel.org>, Gabriel Krisman Bertazi <gabriel@...sman.be>, 
	Hugh Dickins <hughd@...gle.com>, LKML <linux-kernel@...r.kernel.org>, 
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] mm: shmem: Fix variable type to int to evaluate
 negative conditions

On Mon, Dec 23, 2024 at 01:43:09PM +0100, Markus Elfring wrote:
> >> Use signed data type for version handling
> >> in shmem_parse_opt_casefold()
> 
> How do you think about to move this information into the summary phrase?
> 
>
should i add more info to this? as i am still not able to understand
what i need to do here. Can you please suggest what changes are you
suggesting here. 

> …
> >> ---
> >> Coverity Message:
> >> CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
> >> unsigned_compare: This less-than-zero comparison of an unsigned
> >> value is never true. version < 0U
> …
> 
> May such information become a part for the final change description?
>
ofcoure not, as per my understanding, text after '---' are not included
in the change descriptions. (Do correct me if i am wrong here) Thus no
need to worry for them getting added in the change log.

Thank you,
Karan.
> Regards,
> Markus