linux-kernel - Re: [PATCH] mm/kmemleak: Fix percpu memory leak detection failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFULd4bzw-Lj4Hooc2VqGPRyAJf5WcyGSysz+vPaPhvO8ckvDA@mail.gmail.com>
Date: Fri, 27 Dec 2024 11:37:55 +0100
From: Uros Bizjak <ubizjak@...il.com>
To: Guo Weikang <guoweikang.kernel@...il.com>
Cc: Catalin Marinas <catalin.marinas@....com>, Andrew Morton <akpm@...ux-foundation.org>, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/kmemleak: Fix percpu memory leak detection failure

On Fri, Dec 27, 2024 at 10:23 AM Guo Weikang
<guoweikang.kernel@...il.com> wrote:
>
> kmemleak_alloc_percpu gives an incorrect min_count parameter, causing
> percpu memory to be considered a gray object.
>
> Fixes: 8c8685928910 ("mm/kmemleak: use IS_ERR_PCPU() for pointer in the percpu address space")
>
> Signed-off-by: Guo Weikang <guoweikang.kernel@...il.com>

I don't know how 1 turned to 0, the change was definitely unintended.

Acked-by: Uros Bizjak <ubizjak@...il.com>

Thanks,
Uros.

> ---
>  mm/kmemleak.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index 238ab733fbea..982bb5ef3233 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -1093,7 +1093,7 @@ void __ref kmemleak_alloc_percpu(const void __percpu *ptr, size_t size,
>         pr_debug("%s(0x%px, %zu)\n", __func__, ptr, size);
>
>         if (kmemleak_enabled && ptr && !IS_ERR_PCPU(ptr))
> -               create_object_percpu((__force unsigned long)ptr, size, 0, gfp);
> +               create_object_percpu((__force unsigned long)ptr, size, 1, gfp);
>  }
>  EXPORT_SYMBOL_GPL(kmemleak_alloc_percpu);
>
> --
> 2.25.1
>