linux-kernel - Re:Re: [PATCH] dt-bindings: phy: add rk3576 hdptx phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5de24299.9cde.19407b99e5c.Coremail.andyshrk@163.com>
Date: Fri, 27 Dec 2024 18:46:32 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: "Krzysztof Kozlowski" <krzk@...nel.org>
Cc: heiko@...ech.de, cristian.ciocaltea@...labora.com, 
	detlev.casanova@...labora.com, krzk+dt@...nel.org, vkoul@...nel.org, 
	kishon@...nel.org, robh@...nel.org, sebastian.reichel@...labora.com, 
	linux-phy@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	linux-rockchip@...ts.infradead.org, 
	"Andy Yan" <andy.yan@...k-chips.com>
Subject: Re:Re: [PATCH] dt-bindings: phy: add rk3576 hdptx phy


Hi Krzysztof,

At 2024-12-27 16:55:27, "Krzysztof Kozlowski" <krzk@...nel.org> wrote:
>On Tue, Dec 24, 2024 at 05:19:13PM +0800, Andy Yan wrote:
>> From: Andy Yan <andy.yan@...k-chips.com>
>> 
>> The HDPTX PHY on rk3576 is compatible with it on
>> rk3588.
>
>Please wrap commit message according to Linux coding style / submission
>process (neither too early nor over the limit):
>https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
>> 
>> Add compatible for it.
>
>"Add compatible for the HDPTX PHY on rk3576, which is fully compatible
>with foo bar."
>
>One sentence.

Will do in V2, thanks.

>
>> 
>> Signed-off-by: Andy Yan <andy.yan@...k-chips.com>
>> ---
>> 
>>  .../devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml
>> index 84fe59dbcf48..364db2049ce2 100644
>> --- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml
>> @@ -11,8 +11,11 @@ maintainers:
>>  
>>  properties:
>>    compatible:
>> -    enum:
>> -      - rockchip,rk3588-hdptx-phy
>> +    oneOf:
>> +      - const: rockchip,rk3588-hdptx-phy
>> +      - items:
>
>Why items?
>
>> +          - enum:
>
>Why enum?
>
>> +              - rockchip,rk3576-hdptx-phy
>
>So that's just enum with previous entry... but you said compatible, yet
>nothing is here. Test your patches - DTS will fail on this. Driver as
>well (assuming you expressed properly compatibility).

Is this the right way to write it ？：

properties:
   compatible:
-    enum:
-      - rockchip,rk3588-hdptx-phy
+    oneOf:
+      - enum:
+          - rockchip,rk3588-hdptx-phy
+      - items:
+          - enum:
+              - rockchip,rk3576-hdptx-phy
+          - const: rockchip,rk3588-hdptx-phy
>
>Best regards,
>Krzysztof