linux-kernel - Re: [PATCH v7 2/2] tpm: Map the ACPI provided event log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D6MKY8VHP3WT.NKKPW4TC64W8@kernel.org>
Date: Fri, 27 Dec 2024 17:15:25 +0200
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Jarkko Sakkinen" <jarkko@...nel.org>, "Ard Biesheuvel"
 <ardb@...nel.org>
Cc: <linux-integrity@...r.kernel.org>, "Peter Huewe" <peterhuewe@....de>,
 "Jason Gunthorpe" <jgg@...pe.ca>, "Colin Ian King"
 <colin.i.king@...il.com>, "Joe Hattori" <joe@...is.s.u-tokyo.ac.jp>, "James
 Bottomley" <James.Bottomley@...senpartnership.com>, "Stefan Berger"
 <stefanb@...ux.ibm.com>, "Roberto Sassu" <roberto.sassu@...wei.com>, "Al
 Viro" <viro@...iv.linux.org.uk>, "Matthew Garrett" <mjg59@...f.ucam.org>,
 "Andy Liang" <andy.liang@....com>, "Mimi Zohar" <zohar@...ux.ibm.com>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 2/2] tpm: Map the ACPI provided event log

On Fri Dec 27, 2024 at 12:52 PM EET, Jarkko Sakkinen wrote:
> On Fri Dec 27, 2024 at 12:49 PM EET, Jarkko Sakkinen wrote:
> > On Fri Dec 27, 2024 at 10:43 AM EET, Ard Biesheuvel wrote:
> > > On Fri, 27 Dec 2024 at 07:01, Jarkko Sakkinen <jarkko@...nel.org> wrote:
> > > >
> > > > The following failure was reported:
> > > >
> > > > [   10.693310][    T1] tpm_tis STM0925:00: 2.0 TPM (device-id 0x3, rev-id 0)
> > > > [   10.848132][    T1] ------------[ cut here ]------------
> > > > [   10.853559][    T1] WARNING: CPU: 59 PID: 1 at mm/page_alloc.c:4727 __alloc_pages_noprof+0x2ca/0x330
> > > > [   10.862827][    T1] Modules linked in:
> > > > [   10.866671][    T1] CPU: 59 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0-lp155.2.g52785e2-default #1 openSUSE Tumbleweed (unreleased) 588cd98293a7c9eba9013378d807364c088c9375
> > > > [   10.882741][    T1] Hardware name: HPE ProLiant DL320 Gen12/ProLiant DL320 Gen12, BIOS 1.20 10/28/2024
> > > > [   10.892170][    T1] RIP: 0010:__alloc_pages_noprof+0x2ca/0x330
> > > > [   10.898103][    T1] Code: 24 08 e9 4a fe ff ff e8 34 36 fa ff e9 88 fe ff ff 83 fe 0a 0f 86 b3 fd ff ff 80 3d 01 e7 ce 01 00 75 09 c6 05 f8 e6 ce 01 01 <0f> 0b 45 31 ff e9 e5 fe ff ff f7 c2 00 00 08 00 75 42 89 d9 80 e1
> > > > [   10.917750][    T1] RSP: 0000:ffffb7cf40077980 EFLAGS: 00010246
> > > > [   10.923777][    T1] RAX: 0000000000000000 RBX: 0000000000040cc0 RCX: 0000000000000000
> > > > [   10.931727][    T1] RDX: 0000000000000000 RSI: 000000000000000c RDI: 0000000000040cc0
> > > >
> > > > Above shows that ACPI pointed a 16 MiB buffer for the log events because
> > > > RSI maps to the 'order' parameter of __alloc_pages_noprof(). Address the
> > > > bug by mapping the region when needed instead of copying.
> > > >
> > > > Earlier fix does address the warning but wastes 16 MiB of memory. This
> > > > finalizes the fix.
> > > >
> > > > Suggested-by: Matthew Garrett <mjg59@...f.ucam.org>
> > > > Tested-by: Andy Liang <andy.liang@....com>
> > > > Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>
> > >
> > > Where are patch 1/2 and the cover letter?
> >
> > https://lore.kernel.org/linux-integrity/20241227060053.174314-1-jarkko@kernel.org/T/#mc34835f6d6f946c50a580f895f24b7b1dab85204
> >
> > You did not request a cover letter, and I did not think it was
> > really necessary. I can do it for next version on request.
>
> Hmm.. right so this is how I generate Cc's:
>
>     tocmd ="`pwd`/scripts/get_maintainer.pl --norolestats --nol"
>     cccmd ="`pwd`/scripts/get_maintainer.pl --norolestats --nom"
>
> It clearly did not pick you (sorry about that).  I'll add manual cc to
> the next version. And yeah, cover letter is fine, but I did not see any
> (practical) use for it as the patches carry change logs.

I'll reduce this to quick fix after reconsidering. We have the mapped
version drafted and backed up in lore. I'll re-send just that with and
CC you. Or actually I'll put suggested-by tag.

BR, Jarkko