[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Z27JXDwEmplZCDEX@gourry-fedora-PF4VCD3F>
Date: Fri, 27 Dec 2024 10:35:56 -0500
From: Gregory Price <gourry@...rry.net>
To: "Huang, Ying" <ying.huang@...ux.alibaba.com>
Cc: Gregory Price <gourry@...rry.net>,
Joshua Hahn <joshua.hahnjy@...il.com>, hyeonggon.yoo@...com,
kernel_team@...ynix.com, "rafael@...nel.org" <rafael@...nel.org>,
"lenb@...nel.org" <lenb@...nel.org>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
김홍규(KIM HONGGYU) System SW <honggyu.kim@...com>,
김락기(KIM RAKIE) System SW <rakie.kim@...com>,
"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
"Jonathan.Cameron@...wei.com" <Jonathan.Cameron@...wei.com>,
"dave.jiang@...el.com" <dave.jiang@...el.com>,
"horen.chuang@...ux.dev" <horen.chuang@...ux.dev>,
"hannes@...xchg.org" <hannes@...xchg.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"kernel-team@...a.com" <kernel-team@...a.com>
Subject: Re: [External Mail] [RFC PATCH] mm/mempolicy: Weighted interleave
auto-tuning
On Fri, Dec 27, 2024 at 09:59:30AM +0800, Huang, Ying wrote:
> Gregory Price <gourry@...rry.net> writes:
> > This still allows 0 to be a manual "reset specific node to default"
> > mechanism for a specific node, and gives us a clean override.
>
> The difficulty is that users don't know the default value when they
> reset a node's weight. We don't have an interface to show them. So, I
> suggest to disable the functionality: "reset specific node to default".
> They can still use "echo 1 > use_defaults" to reset all nodes to
> default.
>
Good point, and agree. So lets just ditch 0. Since that "feature"
wasn't even functional in the current code (it just reset it to 1 at
this point), it's probably safe to just ditch it. Worst case scenario
if someone takes issues, we can just have it revert the weight to 1.
~Gregory
Powered by blists - more mailing lists