linux-kernel - Re: [PATCH v22 20/20] bpf: Use ftrace_get_symaddr() for kprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241226212453.7b0aa119@batman.local.home>
Date: Thu, 26 Dec 2024 21:24:53 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>, Florent Revest
 <revest@...omium.org>, linux-trace-kernel@...r.kernel.org, LKML
 <linux-kernel@...r.kernel.org>, Martin KaFai Lau <martin.lau@...ux.dev>,
 bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, Jiri Olsa
 <jolsa@...nel.org>, Alan Maguire <alan.maguire@...cle.com>, Mark Rutland
 <mark.rutland@....com>, linux-arch@...r.kernel.org
Subject: Re: [PATCH v22 20/20] bpf: Use ftrace_get_symaddr() for
 kprobe_multi probes

On Thu, 26 Dec 2024 21:23:39 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu, 26 Dec 2024 14:15:25 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> 
> > From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> > 
> > Add ftrace_get_entry_ip() which is only for ftrace based probes, and use
> > it for kprobe multi probes because they are based on fprobe which uses
> > ftrace instead of kprobes.
> > 
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>  
> 
> On my 32bit build, I hit a new warning;
> 
> kernel/trace/bpf_trace.c:1073:22: warning: ‘ftrace_get_entry_ip’ defined but not used [-Wunused-function]
>  1073 | static unsigned long ftrace_get_entry_ip(unsigned long fentry_ip)
>       |                      ^~~~~~~~~~~~~~~~~~~
> 
> Config attached.


Since this is the last patch of the series, just send a new patch for this one.
I'll continue testing the rest of the patches.

-- Steve