linux-kernel - Re: [RFC v2 PATCH 5/5] migrate,sysfs: add pagecache promotion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z27OSxg2ePG_IOuh@gourry-fedora-PF4VCD3F>
Date: Fri, 27 Dec 2024 10:56:59 -0500
From: Gregory Price <gourry@...rry.net>
To: Donet Tom <donettom@...ux.ibm.com>
Cc: Gregory Price <gourry@...rry.net>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, nehagholkar@...a.com,
	abhishekd@...a.com, kernel-team@...a.com, david@...hat.com,
	nphamcs@...il.com, akpm@...ux-foundation.org, hannes@...xchg.org,
	kbusch@...a.com, ying.huang@...ux.alibaba.com
Subject: Re: [RFC v2 PATCH 5/5] migrate,sysfs: add pagecache promotion

On Fri, Dec 27, 2024 at 04:31:48PM +0530, Donet Tom wrote:
> 
> >   		folio_clear_referenced(folio);
> >   		workingset_activation(folio);
> > +	} else {
> > +	
> 
> In the current implementation, promotion will not work if we enable MGLRU,
> right?
> Is there any specific reason we are not enabling promotion with MGLRU?
> 

folio_mark_accessed may not be the best place to interpose for MGLRU,
since MGLRU's semantics are so different.  I didn't want to dive that
deep until I could show traditional LRU benefit.

Certainly open to ideas if you're familiar with MGLRU semantics.

~Gregory