linux-kernel - Re: [PATCH RFC 2/3] pinctrl: Add driver support for Amlogic SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbd5HFzRhoC7qRAb-Kd89fa9sX67aqK9AAMoif3nw9qbQ@mail.gmail.com>
Date: Fri, 27 Dec 2024 18:19:07 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Xianwei Zhao <xianwei.zhao@...ogic.com>, Huqiang Qin <huqiang.qin@...ogic.com>, 
	Qianggui Song <qianggui.song@...ogic.com>, Hyeonki Hong <hhk7734@...il.com>, 
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, 
	Beniamino Galvani <b.galvani@...il.com>, Carlo Caione <carlo@...lessm.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH RFC 2/3] pinctrl: Add driver support for Amlogic SoCs

Newcomers, latest patch set:
https://lore.kernel.org/linux-gpio/20241226-amlogic-pinctrl-v2-0-cdae42a67b76@amlogic.com/

I included some of the prior meson authors on the to line to see if
their mail addresses still work and if they have some feedback on this.

On Sun, Dec 22, 2024 at 10:08 AM Linus Walleij <linus.walleij@...aro.org> wrote:

> > > - Renaming drivers/pinctrl/sunxi to drivers/pinctrl/amlogic
> > >    so we keep this sorted by actual vendor, sunxi is apparently
> > >    yours (AMlogic:s) isn't it?
> >
> > It isn't. Sunxi is Allwinner SoCs.
>
> My apologies. I mixed it up completely. :(

But wait a minute. I see there is meson. And in the "meson" subdirectory
there is stuff named "amlogic" ...

$ ls -1 drivers/pinctrl/meson/
Kconfig
Makefile
pinctrl-amlogic-c3.c
pinctrl-amlogic-t7.c
pinctrl-meson8b.c
pinctrl-meson8.c
pinctrl-meson8-pmx.c
pinctrl-meson8-pmx.h
pinctrl-meson-a1.c
pinctrl-meson-axg.c
pinctrl-meson-axg-pmx.c
pinctrl-meson-axg-pmx.h
pinctrl-meson.c
pinctrl-meson-g12a.c
pinctrl-meson-gxbb.c
pinctrl-meson-gxl.c
pinctrl-meson.h
pinctrl-meson-s4.c

> What do you think of the idea of a separate drivers/pinctrl/amlogic directory
> though? I think there are already quite a few amlogic SoCs that need
> to be supported and more will come.

So what about renaming the existing subdir "meson" to "amlogic"
and put the driver there.

Also I want to know if this driver and hardware shares anything with
the existing drivers in that directory. It sometimes happen that
developers start something from scratch despite the existence of
prior art simply because of organizational issues, and we don't want
that kind of situation to leak over to the kernel.

Yours,
Linus Walleij