linux-kernel - Re: [PATCH v2 3/5] pinctrl: Add driver support for Amlogic SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCCbipebu2sNseNqatfBYdsnW1ouccWBH3N0JTo6GjRG_A@mail.gmail.com>
Date: Fri, 27 Dec 2024 22:11:40 +0100
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: xianwei.zhao@...ogic.com
Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>, 
	Jerome Brunet <jbrunet@...libre.com>, Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH v2 3/5] pinctrl: Add driver support for Amlogic SoCs

Hi Xianwei,

On Thu, Dec 26, 2024 at 8:57 AM Xianwei Zhao via B4 Relay
<devnull+xianwei.zhao.amlogic.com@...nel.org> wrote:
[...]
> +       if (of_property_read_u32(np, "mask", &bank->pc.mux_mask))
> +               bank->pc.mux_mask = 0xf;
I don't see any documentation for the mask property.
The discussion about the dt-bindings is still pretty heated.
Everything else is already part of the documentation (which is good!).
Please document his property as well (or remove the code to read it if
there's no need to have it dynamic).

This is not a full code-review. However, since the discussion about
the whole dt-bindings is still ongoing we need to make sure that
whatever we document in the bindings is actually all that we need to
write the driver.


Best regards,
Martin