linux-kernel - Re: [for-next][PATCH 11/15] tracing: Switch trace_osnoise.c code over to use guard() and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a0cb3d3-3592-40b4-a4c0-85ed10e8dd98@web.de>
Date: Sat, 28 Dec 2024 15:01:51 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Steven Rostedt <rostedt@...dmis.org>, linux-trace-kernel@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Andrew Morton <akpm@...ux-foundation.org>,
 Mark Rutland <mark.rutland@....com>, Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Peter Zijlstra <peterz@...radead.org>
Subject: Re: [for-next][PATCH 11/15] tracing: Switch trace_osnoise.c code over
 to use guard() and __free()

> The osnoise_hotplug_workfn() grabs two mutexes and cpu_read_lock(). It has
> various gotos to handle unlocking them. Switch them over to guard() and
> let the compiler worry about it.
>
> The osnoise_cpus_read() has a temporary mask_str allocated and there's
> some gotos to make sure it gets freed on error paths. Switch that over to
> __free() to let the compiler worry about it.

I would find it safer and cleaner to separate adjustments for these programming interfaces.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13-rc4#n81

Will code transformation concerns be reconsidered any more?

Regards,
Markus