linux-kernel - Re: [PATCH v4 -next 11/15] sunrpc: simplify rpcauth_cache_shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3bd144e59903056b7f4a95a2996bdeaeff6b5024.camel@kernel.org>
Date: Sat, 28 Dec 2024 10:11:21 -0500
From: Jeff Layton <jlayton@...nel.org>
To: Kaixiong Yu <yukaixiong@...wei.com>, akpm@...ux-foundation.org, 
	mcgrof@...nel.org
Cc: ysato@...rs.sourceforge.jp, dalias@...c.org,
 glaubitz@...sik.fu-berlin.de, 	luto@...nel.org, tglx@...utronix.de,
 mingo@...hat.com, bp@...en8.de, 	dave.hansen@...ux.intel.com,
 hpa@...or.com, viro@...iv.linux.org.uk, 	brauner@...nel.org, jack@...e.cz,
 kees@...nel.org, j.granados@...sung.com, 	willy@...radead.org,
 Liam.Howlett@...cle.com, vbabka@...e.cz, 	lorenzo.stoakes@...cle.com,
 trondmy@...nel.org, anna@...nel.org, 	chuck.lever@...cle.com,
 neilb@...e.de, okorniev@...hat.com, Dai.Ngo@...cle.com, 	tom@...pey.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, paul@...l-moore.com, jmorris@...ei.org, 
	linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
 linux-nfs@...r.kernel.org, 	netdev@...r.kernel.org,
 linux-security-module@...r.kernel.org, 	dhowells@...hat.com,
 haifeng.xu@...pee.com, baolin.wang@...ux.alibaba.com, 
	shikemeng@...weicloud.com, dchinner@...hat.com, bfoster@...hat.com, 
	souravpanda@...gle.com, hannes@...xchg.org, rientjes@...gle.com, 
	pasha.tatashin@...een.com, david@...hat.com, ryan.roberts@....com, 
	ying.huang@...el.com, yang@...amperecomputing.com, zev@...ilderbeest.net, 
	serge@...lyn.com, vegard.nossum@...cle.com, wangkefeng.wang@...wei.com
Subject: Re: [PATCH v4 -next 11/15] sunrpc: simplify
 rpcauth_cache_shrink_count()

On Sat, 2024-12-28 at 22:57 +0800, Kaixiong Yu wrote:
> It is inappropriate to use sysctl_vfs_cache_pressure here.
> The sysctl is documented as: This percentage value controls
> the tendency of the kernel to reclaim the memory which is used
> for caching of directory and inode objects.
> 
> So, simplify result of rpcauth_cache_shrink_count() to
> "return number_cred_unused;".
> 
> Signed-off-by: Kaixiong Yu <yukaixiong@...wei.com>
> Reviewed-by: Kees Cook <kees@...nel.org>
> Acked-by: Anna Schumaker <anna.schumaker@...cle.com>
> Acked-by: Jeff Layton <jlayton@...nel.org>
> ---
> v4:
>  - Simplify result of rpcauth_cache_shrink_count().
> ---
> ---
>  net/sunrpc/auth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
> index 04534ea537c8..5a827afd8e3b 100644
> --- a/net/sunrpc/auth.c
> +++ b/net/sunrpc/auth.c
> @@ -489,7 +489,7 @@ static unsigned long
>  rpcauth_cache_shrink_count(struct shrinker *shrink, struct shrink_control *sc)
>  
>  {
> -	return number_cred_unused * sysctl_vfs_cache_pressure / 100;
> +	return number_cred_unused;
>  }
>  
>  static void

No objection here, but this patch seems unrelated to the rest of the
series. Should this go in via Anna or Trond's tree?

Cheers,
-- 
Jeff Layton <jlayton@...nel.org>