linux-kernel - Re: [PATCH] i2c: imx-lpi2c: fix build warning "function defined but not used"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <o4hxr2redr6dp4ot35pbc5vyjldiec6sxy72xesharhphsvdsm@mnufmvmpd2dm>
Date: Sat, 28 Dec 2024 21:53:22 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Carlos Song <carlos.song@....com>
Cc: frank.li@....com, aisheng.dong@....com, shawnguo@...nel.org, 
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, 
	linux-i2c@...r.kernel.org, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] i2c: imx-lpi2c: fix build warning "function defined but
 not used"

Hi Carlos,

On Sat, Dec 28, 2024 at 05:08:52PM +0800, Carlos Song wrote:
> lpi2c_resume_noirq() and lpi2c_suspend_noirq() are defined but it maybe
> unused, so should add __maybe_unused to both functions to avoid build
> warning.
> 
> Fixes: fa89723f7a78 ("i2c: imx-lpi2c: add target mode support")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202412280835.LRAV3z0g-lkp@intel.com/
> Signed-off-by: Carlos Song <carlos.song@....com>

yeah, I have different PM configuration to catch these kind of
error and I missed this.

Rather than applying a fix over a recent patch, I am going to
remove your original patch and ask you to send a v7 of your
"imx-lpi2c: add target mode support".

Is it OK with you?

Andi