linux-kernel - Re: [PATCH] module: Allow DEFAULT_SYMBOL_NAMESPACE be set after export.h included

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3Bv6YhZMAzSLcyg@smile.fi.intel.com>
Date: Sat, 28 Dec 2024 23:38:49 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: David Laight <david.laight.linux@...il.com>
Cc: andi.shyti@...nel.org, masahiroy@...nel.org,
	u.kleine-koenig@...libre.com, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH] module: Allow DEFAULT_SYMBOL_NAMESPACE be set after
 export.h included

On Sat, Dec 28, 2024 at 06:43:28PM +0000, David Laight wrote:
> Commit ceb8bf2ceaa77 ("module: Convert default symbol namespace to string
> literal") changed DEFAULT_SYMBOL_NAMESPACE to be a string literal.
> However the conditional definition of _EXPORT_SYMBOL() was left in.
> 
> Instead just default DEFAULT_SYMBOL_NAMESPACE to "" and remove the
> extra _EXPORT_SYMBOL() wrapper.
> 
> This lets DEFAULT_SYMBOL_NAMESPACE be defined after export.h is included.

> Fixes fd57a3325a779 ("i2c: designware: Move exports to I2C_DW namespaces")

Incorrect format, and this should be a tag.

...

This patch in a different form had been already submitted by Uwe. So, guys, fix
the documentation or clarify it and when you agree on the approach, choose the
patch to review. No Ack till that. Andi, FYI.

-- 
With Best Regards,
Andy Shevchenko