lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202412281640.5vqbPehh-lkp@intel.com>
Date: Sat, 28 Dec 2024 16:41:26 +0800
From: kernel test robot <lkp@...el.com>
To: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	"Fabio M. De Francesco" <fmdefrancesco@...il.com>
Subject: drivers/tty/n_hdlc.c:145: warning: Function parameter or struct
 member 'write_work' not described in 'n_hdlc'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   fd0584d220fe285dc45be43eede55df89ad6a3d9
commit: 1ee33b1ca2b8dabfcc17198ffd049a6b55674a86 tty: n_hdlc: make n_hdlc_tty_wakeup() asynchronous
date:   3 years ago
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20241228/202412281640.5vqbPehh-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 9daf10ff8f29ba3a88a105aaa9d2379c21b77d35)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241228/202412281640.5vqbPehh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412281640.5vqbPehh-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/tty/n_hdlc.c:145: warning: Function parameter or struct member 'write_work' not described in 'n_hdlc'
>> drivers/tty/n_hdlc.c:145: warning: Function parameter or struct member 'tty_for_write_work' not described in 'n_hdlc'


vim +145 drivers/tty/n_hdlc.c

^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  124  
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  125  /**
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  126   * struct n_hdlc - per device instance data structure
724ac070ffc7a1 drivers/tty/n_hdlc.c  Jiri Slaby     2020-08-18  127   * @magic: magic value for structure
724ac070ffc7a1 drivers/tty/n_hdlc.c  Jiri Slaby     2020-08-18  128   * @tbusy: reentrancy flag for tx wakeup code
724ac070ffc7a1 drivers/tty/n_hdlc.c  Jiri Slaby     2020-08-18  129   * @woke_up: tx wakeup needs to be run again as it was called while @tbusy
724ac070ffc7a1 drivers/tty/n_hdlc.c  Jiri Slaby     2020-08-18  130   * @tx_buf_list: list of pending transmit frame buffers
724ac070ffc7a1 drivers/tty/n_hdlc.c  Jiri Slaby     2020-08-18  131   * @rx_buf_list: list of received frame buffers
724ac070ffc7a1 drivers/tty/n_hdlc.c  Jiri Slaby     2020-08-18  132   * @tx_free_buf_list: list unused transmit frame buffers
724ac070ffc7a1 drivers/tty/n_hdlc.c  Jiri Slaby     2020-08-18  133   * @rx_free_buf_list: list unused received frame buffers
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  134   */
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  135  struct n_hdlc {
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  136  	int			magic;
0f238298144250 drivers/tty/n_hdlc.c  Jiri Slaby     2020-02-19  137  	bool			tbusy;
0f238298144250 drivers/tty/n_hdlc.c  Jiri Slaby     2020-02-19  138  	bool			woke_up;
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  139  	struct n_hdlc_buf_list	tx_buf_list;
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  140  	struct n_hdlc_buf_list	rx_buf_list;
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  141  	struct n_hdlc_buf_list	tx_free_buf_list;
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  142  	struct n_hdlc_buf_list	rx_free_buf_list;
1ee33b1ca2b8da drivers/tty/n_hdlc.c  Tetsuo Handa   2021-12-15  143  	struct work_struct	write_work;
1ee33b1ca2b8da drivers/tty/n_hdlc.c  Tetsuo Handa   2021-12-15  144  	struct tty_struct	*tty_for_write_work;
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16 @145  };
^1da177e4c3f41 drivers/char/n_hdlc.c Linus Torvalds 2005-04-16  146  

:::::: The code at line 145 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ