linux-kernel - Re: [PATCH v5 01/15] staging: gpib: Modify gpib_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024122940-irritate-bloated-12de@gregkh>
Date: Sun, 29 Dec 2024 11:30:35 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Nihar Chaithanya <niharchaithanya@...il.com>
Cc: dpenkler@...il.com, dan.carpenter@...aro.org, skhan@...uxfoundation.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 01/15] staging: gpib: Modify gpib_register_driver() to
 return error if it fails

On Sat, Dec 28, 2024 at 11:37:49AM +0530, Nihar Chaithanya wrote:
> The function gpib_register_driver() can fail if kmalloc() fails,
> but it doesn't return any error if that happens.
> 
> Modify the function to return error i.e int. Return the appropriate
> error code if it fails.

You forgot to mention that you removed the pr_info() line.

thanks,

greg k-h