linux-kernel - Re: [PATCH] riscv: Access time mmio instead of rdtime.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241229-cogwheel-kebab-3cc2b21096c8@spud>
Date: Sun, 29 Dec 2024 15:09:13 +0000
From: Conor Dooley <conor@...nel.org>
To: Aleksandar Rikalo <arikalo@...il.com>
Cc: linux-riscv@...ts.infradead.org,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Djordje Todorovic <djordje.todorovic@...cgroup.com>,
	Dragan Mladjenovic <Dragan.Mladjenovic@...mia.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: Access time mmio instead of rdtime.

On Fri, Dec 27, 2024 at 04:00:56PM +0100, Aleksandar Rikalo wrote:
> +#if defined(CONFIG_RISCV_TIME_MMIO)
> +	if (!of_property_read_u64(n, "clock-reg", &mmio_addr)) {

This is a non-standard, undocumented property. reg & reg-names are what
you should be using here.

Cheers,
Conor.

> +		riscv_time_val = ioremap((long)mmio_addr, 8);
> +		if (riscv_time_val) {
> +			pr_info("Using mmio time register at 0x%llx\n", mmio_addr);
> +			static_branch_enable(&riscv_time_mmio_available);
> +		} else {
> +			pr_warn("Unable to use mmio time at 0x%llx\n", mmio_addr);
> +		}
> +	}
> +#endif


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)