linux-kernel - Re: [PATCH 3/5] usb: typec: ucsi: add Huawei Matebook E Go (sc8280xp) ucsi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <231206da-e992-46d9-9998-5b2f1d3e8bb2@web.de>
Date: Sun, 29 Dec 2024 17:15:31 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Pengyu Luo <mitltlatltl@...il.com>, platform-driver-x86@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-pm@...r.kernel.org,
 Bjorn Andersson <andersson@...nel.org>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Hans de Goede <hdegoede@...hat.com>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Sebastian Reichel <sre@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Nikita Travkin <nikita@...n.ru>
Subject: Re: [PATCH 3/5] usb: typec: ucsi: add Huawei Matebook E Go (sc8280xp)
 ucsi driver

> The Huawei Matebook E Go (sc8280xp) tablet provides implements UCSI

                                                      Omit this verb here?


> interface in the onboard EC. …


> +++ b/drivers/platform/arm64/huawei-gaokun-ec.c
> @@ -0,0 +1,598 @@
…
> +static void gaokun_set_orientation(struct ucsi_connector *con,
> +				   struct gaokun_ucsi_port *port)
> +{
…
> +	spin_lock_irqsave(&port->lock, flags);
> +	ccx = port->ccx;
> +	spin_unlock_irqrestore(&port->lock, flags);
> +
> +	typec_set_orientation(con->port, CCX_TO_ORI(ccx));
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&port->lock);”?
https://elixir.bootlin.com/linux/v6.13-rc3/source/include/linux/spinlock.h#L572

Regards,
Markus