linux-kernel - Re: [PATCH v2] cdrom: Fix typo, 'devicen' to 'device'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3GV2W_MUOw5BrtR@equinox>
Date: Sun, 29 Dec 2024 18:32:57 +0000
From: Phillip Potter <phil@...lpotter.co.uk>
To: Steven Davis <goldside000@...look.com>
Cc: linux-kernel@...r.kernel.org, phil@...lpotter.co.uk
Subject: Re: [PATCH v2] cdrom: Fix typo, 'devicen' to 'device'

On Sun, Dec 29, 2024 at 04:57:54PM +0000, Steven Davis wrote:
> Nothing big here, just a typo that really bugged me. :)
> 
> I assume whoever wrote this was trying to make a new
> line, so I went ahead and put a back slash in it.
> 
> Signed-off-by: Steven Davis <goldside000@...look.com>
> ---
> V1 -> V2: Add directory I changed to subject
> 
>  drivers/cdrom/cdrom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index 6a99a459b..2863e5db2 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -1106,7 +1106,7 @@ int open_for_data(struct cdrom_device_info *cdi)
>  		}
>  	}
>  
> -	cd_dbg(CD_OPEN, "all seems well, opening the devicen");
> +	cd_dbg(CD_OPEN, "all seems well, opening the device\n");
>  
>  	/* all seems well, we can open the device */
>  	ret = cdo->open(cdi, 0); /* open for data */
> -- 
> 2.39.5
> 

Hi Steven,

Thank you for the patch, looks good to me. I will forward onto Jens for
inclusion upstream.

Reviewed-by: Phillip Potter <phil@...lpotter.co.uk>

On another note though: The raw patch submission e-mail body seems to have
some encoding issues, evidenced by the presence of extra content on empty
lines:
=20
-	cd_dbg(CD_OPEN, "all seems well, opening the devicen");
+	cd_dbg(CD_OPEN, "all seems well, opening the device\n");
=20

Also, it triggers checkpatch for the same reason:
ERROR: patch seems to be corrupt (line wrapped?)
#165: FILE: drivers/cdrom/cdrom.c:1107:
=20

total: 1 errors, 0 warnings, 11 lines checked

In this instance, happy to send on from yourself with this corrected,
but please do look into why this is happening - it is possibly related
to your e-mail client.

Many thanks.

Regards,
Phil