linux-kernel - Re: [PATCH v3 0/8] i2c: riic: driver cleanup and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vipmrjwnsm3vlv47nysmieuorbwt2gdvdvuhomq3r5b7zlr2g4@hmcb46mujxgq>
Date: Mon, 30 Dec 2024 00:42:35 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Prabhakar <prabhakar.csengg@...il.com>, 
	Chris Brandt <chris.brandt@...esas.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Philipp Zabel <p.zabel@...gutronix.de>, 
	linux-renesas-soc@...r.kernel.org, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v3 0/8] i2c: riic: driver cleanup and improvements

Hi Andy,

On Sun, Dec 29, 2024 at 01:40:54AM +0200, Andy Shevchenko wrote:
> Fri, Dec 27, 2024 at 11:10:22PM +0100, Andi Shyti kirjoitti:
> 
> ...
> 
> > >   i2c: riic: Use dev_err_probe in probe and riic_init_hw functions
> > >   i2c: riic: Use local `dev` pointer in `dev_err_probe()`
> > >   i2c: riic: Use BIT macro consistently
> > >   i2c: riic: Use GENMASK() macro for bitmask definitions
> > >   i2c: riic: Make use of devres helper to request deasserted reset line
> > >   i2c: riic: Mark riic_irqs array as const
> > >   i2c: riic: Use predefined macro and simplify clock tick calculation
> > >   i2c: riic: Add `riic_bus_barrier()` to check bus availability
> > 
> > merged to i2c/i2c-host.
> 
> There are some comments, up to you how to proceed, they seem not to be any
> critical.

first of all, welcome back :-)

I'd like the comments to be addressed, even if they are not
critical.

So that I'm going to remove this series for now until there are
no more questions.

Thanks for looking into this series,
Andi