linux-kernel - sound/core/compress_offload.c:1071:5-11: inconsistent IS_ERR and PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202412290846.cncnpGaw-lkp@intel.com>
Date: Sun, 29 Dec 2024 08:22:19 +0800
From: kernel test robot <lkp@...el.com>
To: Jaroslav Kysela <perex@...ex.cz>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>,
	Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>
Subject: sound/core/compress_offload.c:1071:5-11: inconsistent IS_ERR and
 PTR_ERR on line 1072.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   059dd502b263d8a4e2a84809cf1068d6a3905e6f
commit: 04177158cf98a79744937893b100020d77e6f9ac ALSA: compress_offload: introduce accel operation mode
date:   9 weeks ago
config: i386-randconfig-054-20241229 (https://download.01.org/0day-ci/archive/20241229/202412290846.cncnpGaw-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412290846.cncnpGaw-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> sound/core/compress_offload.c:1071:5-11: inconsistent IS_ERR and PTR_ERR on line 1072.
   sound/core/compress_offload.c:1132:5-11: inconsistent IS_ERR and PTR_ERR on line 1133.
   sound/core/compress_offload.c:1223:5-11: inconsistent IS_ERR and PTR_ERR on line 1224.

vim +1071 sound/core/compress_offload.c

  1062	
  1063	static int snd_compr_task_create(struct snd_compr_stream *stream, unsigned long arg)
  1064	{
  1065		struct snd_compr_task *task __free(kfree) = NULL;
  1066		int retval;
  1067	
  1068		if (stream->runtime->state != SNDRV_PCM_STATE_SETUP)
  1069			return -EPERM;
  1070		task = memdup_user((void __user *)arg, sizeof(*task));
> 1071		if (IS_ERR(task))
> 1072			return PTR_ERR(no_free_ptr(task));
  1073		retval = snd_compr_task_new(stream, task);
  1074		if (retval >= 0)
  1075			if (copy_to_user((void __user *)arg, task, sizeof(*task)))
  1076				retval = -EFAULT;
  1077		return retval;
  1078	}
  1079	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki