linux-kernel - [PATCH V2] lib: Fix return check in 842

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241229063944.2252-1-tanyaagarwal25699@gmail.com>
Date: Sun, 29 Dec 2024 12:09:45 +0530
From: Tanya Agarwal <tanyaagarwal25699@...il.com>
To: haren@...ibm.com
Cc: Markus.Elfring@....de,
	kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org,
	anupnewsmail@...il.com,
	tanyaagarwal25699@...il.com
Subject: [PATCH V2] lib: Fix return check in 842_compress.c

From: Tanya Agarwal <tanyaagarwal25699@...il.com>

Improve error handling in sw842_compress() for add_repeat_template().
Note that this error case is already properly handled later in other
add_repeat_template() function calls.

CID 1309755: (#1 of 1): Unused value (UNUSED_VALUE)
returned_value: Assigning value from add_repeat_template(p, repeat_count)
to ret here, but that stored value is overwritten before it can be used.

Coverity Link:
https://scan5.scan.coverity.com/#/project-view/63683/10063?selectedIssue=1309755

Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")
Signed-off-by: Tanya Agarwal <tanyaagarwal25699@...il.com>
---
Changes in V2:
- Updated commit msg
- Link to V1: https://lore.kernel.org/all/20241228074246.3572-1-tanyaagarwal25699@gmail.com
---
 lib/842/842_compress.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/842/842_compress.c b/lib/842/842_compress.c
index c02baa4168e1..055356508d97 100644
--- a/lib/842/842_compress.c
+++ b/lib/842/842_compress.c
@@ -532,6 +532,8 @@ int sw842_compress(const u8 *in, unsigned int ilen,
 		}
 		if (repeat_count) {
 			ret = add_repeat_template(p, repeat_count);
+			if (ret)
+				return ret;
 			repeat_count = 0;
 			if (next == last) /* reached max repeat bits */
 				goto repeat;
-- 
2.39.5