linux-kernel - Re: [PATCH v2] ALSA: hda: Support for Ideapad hotkey mute LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ikr2dfnc.wl-tiwai@suse.de>
Date: Sun, 29 Dec 2024 10:04:07 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Jackie Dong <xy-jackie@....com>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	bo.liu@...arytech.com,
	kovalev@...linux.org,
	me@...herl.one,
	jaroslaw.janik@...il.com,
	songxiebing@...inos.cn,
	kailang@...ltek.com,
	sbinding@...nsource.cirrus.com,
	simont@...nsource.cirrus.com,
	josh@...huagrisham.com,
	rf@...nsource.cirrus.com,
	linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org,
	linux-sound@...r.kernel.org,
	mpearson-lenovo@...ebb.ca,
	dongeg1@...ovo.com
Subject: Re: [PATCH v2] ALSA: hda: Support for Ideapad hotkey mute LEDs

On Tue, 24 Dec 2024 09:33:16 +0100,
Jackie Dong wrote:
> 
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6934,6 +6934,16 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec,
>  	hda_fixup_thinkpad_acpi(codec, fix, action);
>  }
>  
> +/* for hda_fixup_ideapad_acpi() */
> +#include "ideapad_hotkey_led_helper.c"
> +
> +static void alc_fixup_ideapad_acpi(struct hda_codec *codec,
> +				   const struct hda_fixup *fix, int action)
> +{
> +	alc_fixup_no_shutup(codec, fix, action); /* reduce click noise */
> +	hda_fixup_ideapad_acpi(codec, fix, action);
> +}

So this unconditionally call alc_fixup_no_shutup(), and this
introduces another behavior to the existing entry -- i.e. there is a
chance of breakage.

If we want to be very conservative, this call should be limited to
Ideapad.


thanks,

Takashi