linux-kernel - [tip: x86/urgent] virt: tdx-guest: Just leak decrypted memory on unrecoverable errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <173546448435.399.8616425027879023490.tip-bot2@tip-bot2>
Date: Sun, 29 Dec 2024 09:28:04 -0000
From: "tip-bot2 for Li RongQing" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Li RongQing <lirongqing@...du.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>, Ingo Molnar <mingo@...nel.org>,
 Rick Edgecombe <rick.p.edgecombe@...el.com>,
 "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
 stable@...r.kernel.org, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: [tip: x86/urgent] virt: tdx-guest: Just leak decrypted memory on
 unrecoverable errors

The following commit has been merged into the x86/urgent branch of tip:

Commit-ID:     27834971f616c5e154423c578fa95e0444444ce1
Gitweb:        https://git.kernel.org/tip/27834971f616c5e154423c578fa95e0444444ce1
Author:        Li RongQing <lirongqing@...du.com>
AuthorDate:    Wed, 19 Jun 2024 19:18:01 +08:00
Committer:     Ingo Molnar <mingo@...nel.org>
CommitterDate: Sun, 29 Dec 2024 10:18:44 +01:00

virt: tdx-guest: Just leak decrypted memory on unrecoverable errors

In CoCo VMs it is possible for the untrusted host to cause
set_memory_decrypted() to fail such that an error is returned
and the resulting memory is shared. Callers need to take care
to handle these errors to avoid returning decrypted (shared)
memory to the page allocator, which could lead to functional
or security issues.

Leak the decrypted memory when set_memory_decrypted() fails,
and don't need to print an error since set_memory_decrypted()
will call WARN_ONCE().

Fixes: f4738f56d1dc ("virt: tdx-guest: Add Quote generation support using TSM_REPORTS")
Signed-off-by: Li RongQing <lirongqing@...du.com>
Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
Signed-off-by: Ingo Molnar <mingo@...nel.org>
Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com>
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
Cc: stable@...r.kernel.org
Link: https://lore.kernel.org/all/20240619111801.25630-1-lirongqing%40baidu.com
---
 drivers/virt/coco/tdx-guest/tdx-guest.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/virt/coco/tdx-guest/tdx-guest.c b/drivers/virt/coco/tdx-guest/tdx-guest.c
index d7db6c8..224e7dd 100644
--- a/drivers/virt/coco/tdx-guest/tdx-guest.c
+++ b/drivers/virt/coco/tdx-guest/tdx-guest.c
@@ -124,10 +124,8 @@ static void *alloc_quote_buf(void)
 	if (!addr)
 		return NULL;

-	if (set_memory_decrypted((unsigned long)addr, count)) {
-		free_pages_exact(addr, len);
+	if (set_memory_decrypted((unsigned long)addr, count))
 		return NULL;
-	}

 	return addr;
 }