[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMj1kXHWoD78QdFnEY_=Mtz02zN3rhN5+Skgv=fHG91TD8Mmvw@mail.gmail.com>
Date: Sun, 29 Dec 2024 11:08:55 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Lukas Wunner <lukas@...ner.de>
Cc: Lleyton Gray <lleyton@...alabs.com>, gargaditya08@...e.com,
linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Subject: Re: [PATCH] x86/efistub: Add options for forcing Apple set_os protocol
On Sun, 29 Dec 2024 at 11:00, Lukas Wunner <lukas@...ner.de> wrote:
>
> On Sat, Dec 28, 2024 at 12:21:58PM -0800, Lleyton Gray wrote:
> > commit 71e49eccdca6 ("x86/efistub: Call Apple set_os protocol on dual GPU
> > Intel Macs") calls the Apple set_os protocol, but only on T2 Macbook Pro
> > models. This causes issues on other T2 models when an egpu is used.
>
> How so? The commit specifically constrains the quirk only to
> affected dual GPU MacBook Pros. So I don't quite see how this
> would affect other T2 models?
>
> And what kind of issues are you seeing? Could you provide
> specifics please?
>
> > Add two options which allow force enabling or disabling usage of the
> > protocol to fix.
>
> We generally try to avoid command line options. The kernel
> should automatically determine whether to apply the quirk
> or not. So I think the proper solution is to amend the
> quirk such that it's applied to additional models or not
> applied under certain circumstances.
>
Indeed.
But first I'd like to understand whether this is really the same
issue, or another issue that requires the quirk.
IIRC, the original issue is about not being able to use the discrete
GPU with the built-in panel, and the issue about an external GPU did
come up in the discussion - however, this does not affect the built-in
panel at all.
Powered by blists - more mailing lists