linux-kernel - [PATCH] scsi: qla2xxx: Remove duplicate fcport release in error handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20241230065041.67315-1-haoqinhuang7@gmail.com>
Date: Mon, 30 Dec 2024 14:50:41 +0800
From: haoqinhuang <haoqinhuang7@...il.com>
To: njavali@...vell.com,
	GR-QLogic-Storage-Upstream@...vell.com,
	James.Bottomley@...senPartnership.com,
	martin.petersen@...cle.com,
	himanshu.madhani@...cle.com,
	skashyap@...vell.com
Cc: linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	haoqinhuang <haoqinhuang@...cent.com>,
	Haisu Wang <haisuwang@...cent.com>
Subject: [PATCH] scsi: qla2xxx: Remove duplicate fcport release in error handler

From: haoqinhuang <haoqinhuang@...cent.com>

After calling function qla2x00_sp_release(), the system automatically
executes the function qla2x00_free_fcport(sp->fcport).

A closer inspection of qla2x00_sp_release() reveals that it triggers a
call to sp->free(sp), where sp->free points to qla2x00_els_dcmd_sp_free.
In function qla2x00_els_dcmd_sp_free(), if sp->fcport exists,
qla2x00_free_fcport(sp->fcport) is triggered.

Given this sequence of events, calling qla2x00_free_fcport(sp->fcport)
again during qla2x00_sp_release() is duplicate. This redundant call
should be eliminated.

Fixes: 82f522ae0d97 ("scsi: qla2xxx: Fix double free of fcport")
Signed-off-by: Haisu Wang <haisuwang@...cent.com>
Signed-off-by: haoqinhuang <haoqinhuang@...cent.com>
---
 drivers/scsi/qla2xxx/qla_iocb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 0b41e8a06602..faec66bd1951 100644
--- a/drivers/scsi/qla2xxx/qla_iocb.c
+++ b/drivers/scsi/qla2xxx/qla_iocb.c
@@ -2751,7 +2751,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (!elsio->u.els_logo.els_logo_pyld) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
@@ -2776,7 +2775,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (rval != QLA_SUCCESS) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
-- 
2.43.5