linux-kernel - Re: [PATCH v3] PCI: endpoint: pci-epf-test: Fix NULL ptr assignment to dma_chan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241230072645.6x4awglfwbjis27e@thinkpad>
Date: Mon, 30 Dec 2024 12:56:45 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Mohamed Khalfella <khalfella@...il.com>
Cc: Frank.Li@....com, bhelgaas@...gle.com, cassel@...nel.org,
	dlemoal@...nel.org, jiangwang@...inos.cn, kishon@...nel.org,
	kw@...ux.com, kwilczynski@...nel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH v3] PCI: endpoint: pci-epf-test: Fix NULL ptr assignment
 to dma_chan_rx

On Fri, Dec 27, 2024 at 08:08:41AM -0800, Mohamed Khalfella wrote:
> If dma_chan_tx allocation fails, set dma_chan_rx to NULL after it is
> freed.
> 
> Fixes: 8353813c88ef ("PCI: endpoint: Enable DMA tests for endpoints with DMA capabilities")
> Signed-off-by: Mohamed Khalfella <khalfella@...il.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Btw, you are sending next version as a reply to the previous one. But you should
send it separately.

- Mani

> Reviewed-by: Niklas Cassel <cassel@...nel.org>
> ---
>  drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index ef6677f34116..d90c8be7371e 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -251,7 +251,7 @@ static int pci_epf_test_init_dma_chan(struct pci_epf_test *epf_test)
>  
>  fail_back_rx:
>  	dma_release_channel(epf_test->dma_chan_rx);
> -	epf_test->dma_chan_tx = NULL;
> +	epf_test->dma_chan_rx = NULL;
>  
>  fail_back_tx:
>  	dma_cap_zero(mask);
> -- 
> 2.45.2
> 

-- 
மணிவண்ணன் சதாசிவம்