linux-kernel - Re: [PATCH] pinctrl: Fix the clean up on pinconf_apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN3W6UX0xEirheAZH2VS0y133i6nfH4vM72wVD5xcO=3CrCCrA@mail.gmail.com>
Date: Mon, 30 Dec 2024 13:05:13 +0530
From: Mukesh Ojha <mukesh.ojha@....qualcomm.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: Fix the clean up on pinconf_apply_setting failure

On Fri, Dec 27, 2024 at 9:40 PM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> Hi Mukesh,
>
> thanks for your patch!
>
> On Tue, Dec 24, 2024 at 9:45 AM Mukesh Ojha
> <mukesh.ojha@....qualcomm.com> wrote:
>
> > When some client does devm_pinctrl_get() followed by
> > pinctrl_select_state() that does pinmux first successfully and later
> > during config setting it sets the wrong drive strenght to the pin due to
> > which pinconf_apply_setting fails. Currently, on failure during config
> > setting is implemented as if pinmux has failed for one of the pin but
> > that does not seem right and need to undo the pinmux for all the pin if
> > config setting fails.
> >
> > Current commit does a bit refactor to reuse the code and tries to clean
> > up mux setting on config setting failure.
> >
> > Signed-off-by: Mukesh Ojha <mukesh.ojha@....qualcomm.com>
>
> Hats off, it's a real nice patch. I bet these are design flaws from
> my initial implementation ~13 years ago.
>
> I have applied it for -next (v6.14) while we test it in linux-next and
> think about if we should even back-port this to stable.

Thanks, Let me know if you want me to send another version with tagging
it stable and Fixes tag.

-Mukesh

>
> Yours,
> Linus Walleij