linux-kernel - Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b811d4af6a634d61389dfefacd49853c0e77f1d7.camel@sipsolutions.net>
Date: Mon, 30 Dec 2024 09:22:28 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>, Andrew Lunn	
 <andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet	 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni	 <pabeni@...hat.com>, Geoff Levand <geoff@...radead.org>, Simon
 Horman	 <horms@...nel.org>, Alexander Lobakin
 <aleksander.lobakin@...el.com>, 	netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Kalle Valo <kvalo@...nel.org>, Alexandre Belloni	
 <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
  Geert Uytterhoeven <geert@...ux-m68k.org>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Jeff Johnson	 <quic_jjohnson@...cinc.com>,
 Larry Finger <Larry.Finger@...inger.net>,  Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Pavel Machek <pavel@....cz>, Stanislaw
 Gruszka <stf_xl@...pl>,  Gregory Greenman <gregory.greenman@...el.com>,
 linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, 
	linux-staging@...ts.linux.dev, linux-wireless@...r.kernel.org, Arnd
 Bergmann	 <arnd@...db.de>, Stefan Lippers-Hollmann <s.l-h@....de>
Subject: Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove
 driver using deprecated API wext

On Tue, 2024-12-24 at 09:07 +0100, Philipp Hortmann wrote:
> Driver was contributed in 2008.
> 
> The following reasons lead to the removal:
> - This driver generates maintenance workload for itself and for API wext

So I've been wondering, why are you so concerned about this? And in
particular, more concerned about it than the people actually doing the
maintenance? :)

We got here because I removed a *staging* driver that was in the way of
some wext cleanups, but that had a thousand other reasons to never go
anywhere anyway.

> - wext is deprecated and only used by two wireless drivers in
>   mainline kernel

true

> - no progress changing to mac80211

It fundamentally cannot be converted to mac80211, it has a whole
different model. In fact it cannot even be converted to cfg80211 because
some APIs it uses just never existed there, and likely never will.

> Tested a rebased version of this patch on the Playstation 3. Used
> T2 Linux with Kernel 6.12.5 to test the Ethernet connection.
> 

Arguably that's a pretty strong argument for *not* removing it, if it's
actually relatively simple today to bring up the latest kernel on a PS3.

johannes