linux-kernel - Re: [PATCH v3 4/7] mtd: spinand: add start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o70t7cpl.fsf@bootlin.com>
Date: Mon, 30 Dec 2024 10:16:22 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Martin Kurbanov <mmkurbanov@...utedevices.com>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Ezra Buehler <ezra.buehler@...qvarnagroup.com>,
  Alexey Romanov <avromanov@...utedevices.com>,  Frieder Schrempf
 <frieder.schrempf@...tron.de>,  <linux-kernel@...r.kernel.org>,
  <linux-mtd@...ts.infradead.org>,  <kernel@...utedevices.com>
Subject: Re: [PATCH v3 4/7] mtd: spinand: add start_page to otp layout

On 26/12/2024 at 16:55:49 +03, Martin Kurbanov <mmkurbanov@...utedevices.com> wrote:

> The OTP area is divided into two parts: the factory and the user.
> In SPI-NAND, it is usually this one OTP region: the first few pages
> are

(this sentence might be reworded, it is not very clear)

> allocated to the factory area. Therefore, enter the start_page field,
> which indicates from which page the custom OTP region starts.

TBH I don't like this shortcut and I would prefer having:
- two otp structures defining each parts (user/factory)
- both the user and factory otp hooks provided
- perhaps a top level macro which does both initializations based on
the (user_otp_)start_page parameter.

But I don't like much hiding the layout subtlety behind a
"start_page" member (although it should probably be named
"user_area_start_page" or something like that, otherwise it's
misleading).

This would also be more future proof, manufacturers are creative.

Thanks,
Miquèl