linux-kernel - Re: [RESEND PATCH] ASoC: SOF: Intel: Use str_yes_no() helper in atom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16db44f0-38a7-48c6-a7f5-5d200acd9868@linux.intel.com>
Date: Mon, 30 Dec 2024 11:38:11 +0200
From: Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 Liam Girdwood <lgirdwood@...il.com>,
 Bard Liao <yung-chuan.liao@...ux.intel.com>,
 Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
 Daniel Baluta <daniel.baluta@....com>,
 Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
 Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Greg KH <gregkh@...uxfoundation.org>,
 Peter Zijlstra <peterz@...radead.org>
Cc: sound-open-firmware@...a-project.org, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] ASoC: SOF: Intel: Use str_yes_no() helper in
 atom_dump()



On 30/12/2024 10:57, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_yes_no() helper function.

Acked-by: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>

> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  sound/soc/sof/intel/atom.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/sound/soc/sof/intel/atom.c b/sound/soc/sof/intel/atom.c
> index 30e981c558c6..0d364bcdcfa9 100644
> --- a/sound/soc/sof/intel/atom.c
> +++ b/sound/soc/sof/intel/atom.c
> @@ -78,20 +78,20 @@ void atom_dump(struct snd_sof_dev *sdev, u32 flags)
>  	imrd = snd_sof_dsp_read64(sdev, DSP_BAR, SHIM_IMRD);
>  	dev_err(sdev->dev,
>  		"error: ipc host -> DSP: pending %s complete %s raw 0x%llx\n",
> -		(panic & SHIM_IPCX_BUSY) ? "yes" : "no",
> -		(panic & SHIM_IPCX_DONE) ? "yes" : "no", panic);
> +		str_yes_no(panic & SHIM_IPCX_BUSY),
> +		str_yes_no(panic & SHIM_IPCX_DONE), panic);
>  	dev_err(sdev->dev,
>  		"error: mask host: pending %s complete %s raw 0x%llx\n",
> -		(imrx & SHIM_IMRX_BUSY) ? "yes" : "no",
> -		(imrx & SHIM_IMRX_DONE) ? "yes" : "no", imrx);
> +		str_yes_no(imrx & SHIM_IMRX_BUSY),
> +		str_yes_no(imrx & SHIM_IMRX_DONE), imrx);
>  	dev_err(sdev->dev,
>  		"error: ipc DSP -> host: pending %s complete %s raw 0x%llx\n",
> -		(status & SHIM_IPCD_BUSY) ? "yes" : "no",
> -		(status & SHIM_IPCD_DONE) ? "yes" : "no", status);
> +		str_yes_no(status & SHIM_IPCD_BUSY),
> +		str_yes_no(status & SHIM_IPCD_DONE), status);
>  	dev_err(sdev->dev,
>  		"error: mask DSP: pending %s complete %s raw 0x%llx\n",
> -		(imrd & SHIM_IMRD_BUSY) ? "yes" : "no",
> -		(imrd & SHIM_IMRD_DONE) ? "yes" : "no", imrd);
> +		str_yes_no(imrd & SHIM_IMRD_BUSY),
> +		str_yes_no(imrd & SHIM_IMRD_DONE), imrd);
>  
>  }
>  EXPORT_SYMBOL_NS(atom_dump, "SND_SOC_SOF_INTEL_ATOM_HIFI_EP");

-- 
Péter