linux-kernel - Re: [PATCH] module: Allow DEFAULT_SYMBOL_NAMESPACE be set after export.h included

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ytxbpm4zmausomklykqeqaw3nnkaurqwsi76uejgq655ylmxyd@ubbetotmrqo3>
Date: Mon, 30 Dec 2024 10:42:55 +0100
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: David Laight <david.laight.linux@...il.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, andi.shyti@...nel.org, 
	andriy.shevchenko@...ux.intel.com, masahiroy@...nel.org, linux-kernel@...r.kernel.org, 
	linux-i2c@...r.kernel.org
Subject: Re: [PATCH] module: Allow DEFAULT_SYMBOL_NAMESPACE be set after
 export.h included

On Sun, Dec 29, 2024 at 12:59:36AM +0000, David Laight wrote:
> On Sat, 28 Dec 2024 15:29:24 -0800
> Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> > On Sat, 28 Dec 2024 at 10:43, David Laight <david.laight.linux@...il.com> wrote:
> > >
> > > Instead just default DEFAULT_SYMBOL_NAMESPACE to "" and remove the
> > > extra _EXPORT_SYMBOL() wrapper.
> > >
> > > This lets DEFAULT_SYMBOL_NAMESPACE be defined after export.h is included.  
> > 
> > Grr. This is horribly ugly.
> 
> I thought it was a neater 'ugly' than the current definitions in export.h
> 
> > I think the i2c code should just be fixed to use the proper "define
> > namespace early".
> 
> The i2c changes were needed because I found the code wouldn't compile.
> It is pretty easy mistake to make and will happen again.

There is
https://lore.kernel.org/linux-i2c/20241203173640.1648939-2-u.kleine-koenig@baylibre.com
that moves the DEFAULT_SYMBOL_NAMESPACE above the #include block for the
i2c driver. Though it seems I missed ...master.c. (I'll address that.)

> and does - I missed drivers/pwm/pwm-lpss.c drivers/hwmon/nct6775-core.c
> and drivers/pwm/pwm-lpss.c

drivers/pwm/pwm-lpss.c is addressed by
https://lore.kernel.org/linux-pwm/cover.1733245406.git.ukleinek@kernel.org

the hwmon driver is addressed by
https://lore.kernel.org/linux-hwmon/20241203173149.1648456-2-u.kleine-koenig@baylibre.com
(and applied in next)

There is also drivers/gpio/gpio-idio-16.c (which I guess you intended to
list instead of the pwm driver twice), which I sent a patch for at
https://lore.kernel.org/linux-gpio/20241203172631.1647792-2-u.kleine-koenig@baylibre.com
(also already applied in next).

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)