linux-kernel - Re: [PATCH] acpi/ghes: Make ghes_panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241230101658.GAZ3JzGhRjn7UtoJPt@fat_crate.local>
Date: Mon, 30 Dec 2024 11:16:58 +0100
From: Borislav Petkov <bp@...en8.de>
To: "Huang, Ying" <ying.huang@...ux.alibaba.com>
Cc: Feng Tang <feng.tang@...ux.alibaba.com>, rafael@...nel.org,
	Len Brown <lenb@...nel.org>, James Morse <james.morse@....com>,
	Tony Luck <tony.luck@...el.com>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ira Weiny <ira.weiny@...el.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] acpi/ghes: Make ghes_panic_timeout adjustable as a
 parameter

On Mon, Dec 30, 2024 at 01:54:36PM +0800, Huang, Ying wrote:
> For example, it may be OK to wait forever for a software error, but it may
> be better to reboot the system to contain the influence of the hardware
> error for some hardware errors.

A default panic timeout of 30 seconds for hw errors?! You do realize that 30
seconds for a machine is an eternity and by that time your hardware error has
long propagated and corrupted results, right?

So your timeout is not even trying to do what you want.

So unless I'm missing something, this ghes timeout needs to go - if you want
to "contain the influence" you need to panic *immediately*! And not even that
would help in some cases - hw has its own protections there so the OS
panicking is meh. At least on x86, that is.

> So, we introduced another knob for that.

No, that another knob is piling more of the silly ontop.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette