linux-kernel - Re: [PATCH] crypto: keywrap - remove unused keywrap algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWMCqXzDOKfywKaYvsz60zsdt6OTeUJGZNLotDb017FXA@mail.gmail.com>
Date: Mon, 30 Dec 2024 12:06:07 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Stephan Mueller <smueller@...onox.de>
Subject: Re: [PATCH] crypto: keywrap - remove unused keywrap algorithm

On Fri, Dec 27, 2024 at 11:10 PM Eric Biggers <ebiggers@...nel.org> wrote:
> From: Eric Biggers <ebiggers@...gle.com>
>
> The keywrap (kw) algorithm has no in-tree user.  It has never had an
> in-tree user, and the patch that added it provided no justification for
> its inclusion.  Even use of it via AF_ALG is impossible, as it uses a
> weird calling convention where part of the ciphertext is returned via
> the IV buffer, which is not returned to userspace in AF_ALG.
>
> It's also unclear whether any new code in the kernel that does key
> wrapping would actually use this algorithm.  It is controversial in the
> cryptographic community due to having no clearly stated security goal,
> no security proof, poor performance, and only a 64-bit auth tag.  Later
> work (https://eprint.iacr.org/2006/221) suggested that the goal is
> deterministic authenticated encryption.  But there are now more modern
> algorithms for this, and this is not the same as key wrapping, for which
> a regular AEAD such as AES-GCM usually can be (and is) used instead.
>
> Therefore, remove this unused code.
>
> There were several special cases for this algorithm in the self-tests,
> due to its weird calling convention.  Remove those too.
>
> Cc: Stephan Mueller <smueller@...onox.de>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

>  arch/m68k/configs/amiga_defconfig          |   1 -
>  arch/m68k/configs/apollo_defconfig         |   1 -
>  arch/m68k/configs/atari_defconfig          |   1 -
>  arch/m68k/configs/bvme6000_defconfig       |   1 -
>  arch/m68k/configs/hp300_defconfig          |   1 -
>  arch/m68k/configs/mac_defconfig            |   1 -
>  arch/m68k/configs/multi_defconfig          |   1 -
>  arch/m68k/configs/mvme147_defconfig        |   1 -
>  arch/m68k/configs/mvme16x_defconfig        |   1 -
>  arch/m68k/configs/q40_defconfig            |   1 -
>  arch/m68k/configs/sun3_defconfig           |   1 -
>  arch/m68k/configs/sun3x_defconfig          |   1 -

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org> # m68k

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds