linux-kernel - Re: [PATCH] acpi/ghes: Make ghes_panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3KaSxr2sjCC8FpJ@U-2FWC9VHC-2323.local>
Date: Mon, 30 Dec 2024 21:04:11 +0800
From: Feng Tang <feng.tang@...ux.alibaba.com>
To: Borislav Petkov <bp@...en8.de>
Cc: "Huang, Ying" <ying.huang@...ux.alibaba.com>, rafael@...nel.org,
	Len Brown <lenb@...nel.org>, James Morse <james.morse@....com>,
	Tony Luck <tony.luck@...el.com>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ira Weiny <ira.weiny@...el.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] acpi/ghes: Make ghes_panic_timeout adjustable as a
 parameter

On Mon, Dec 30, 2024 at 01:10:09PM +0100, Borislav Petkov wrote:
> On Mon, Dec 30, 2024 at 07:40:18PM +0800, Feng Tang wrote:
> > Still we may need to honor the user setting, say if user specifically set
> > "panic=XXX" in the cmdline, we should detect that case and skip overwritting
> > the panic_timeout? 
> 
> So the user has set panic timeout to something, machine encounters a hw error
> which you want to log/report earlier but user's panic setting prevents you
> from doing that.
> 
> So what do you do?
> 
> What has higher prio?
> 
> I guess we're something like this:
> 
> https://youtu.be/gLFQystE8vU?t=71

Hah!

As per kernel config, most ARCH has 'panic_timeout' as 0 by default, so
need to set the kcmdline. For the case in my commit log, where user had
clear requirement for not-reboot and wait, the manually set 'panic=0'
should take priority here?  

Thanks,
Feng

> 
> :-P
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette