[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <71c6609e-e853-4680-939e-f3c9ec15233e@oss.qualcomm.com>
Date: Mon, 30 Dec 2024 14:27:07 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Yongxing Mou <quic_yongmou@...cinc.com>,
Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Ritesh Kumar <quic_riteshk@...cinc.com>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: qcs8300: add DisplayPort device
nodes
On 26.12.2024 8:03 AM, Yongxing Mou wrote:
>
>
> On 2024/12/6 5:36, Konrad Dybcio wrote:
>> On 27.11.2024 11:45 AM, Yongxing Mou wrote:
>>> Add device tree nodes for the DPTX0 controller with their
>>> corresponding PHYs found on Qualcomm QCS8300 SoC.
>>>
>>> Signed-off-by: Yongxing Mou <quic_yongmou@...cinc.com>
>>> ---
[...]
>>> + mdss_dp0_phy: phy@...2a00 {
>>> + compatible = "qcom,qcs8300-edp-phy";
>>> +
>>> + reg = <0x0 0x0aec2a00 0x0 0x200>,
>>
>> 0x19c
>>
> got it.thanks.
>>> + <0x0 0x0aec2200 0x0 0xd0>,
>>
>> 0xec
> got it.thanks.
>>> + <0x0 0x0aec2600 0x0 0xd0>,
>>
>> 0xec
>>
>> For lengths
> got it.thanks.
>>
>>> + <0x0 0x0aec2000 0x0 0x1c8>;
>>
>> This one's correct
>>
>>> +
>>> + clocks = <&dispcc MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
>>> + <&dispcc MDSS_DISP_CC_MDSS_AHB_CLK>;
>>> + clock-names = "aux",
>>> + "cfg_ahb";
>>
>> power-domains = <&rpmhpd RPMHPD_MX>;
>>
> emm,we use RPMHPD_MMCX in qcs8300 mdss and dpu..
>> (or maybe even MXC?)
Please verify what backs the PHY and update accordingly
Konrad
Powered by blists - more mailing lists